Skip to content

fix(macOS): Build for Apple Silicon - #248

Open
tobias-wilfert wants to merge 5 commits into
git-learning-game:mainfrom
tobias-wilfert:main
Open

tobias-wilfert wants to merge 5 commits into
git-learning-game:mainfrom
tobias-wilfert:main

Conversation

@tobias-wilfert

Copy link
Copy Markdown

The goal of this PR is to produce a 'native' Mac build, this is achieved by updating the build.yml to use Godot version 3.6 which generates a 'native' build instead of an Intel one.

On top of that this PR also does the following:

  • Add the Publish to GitHub Release step (this is done mainly for testing and so that people can download the build from the fork while the PR is not yet merged).
  • Rather than just bump the barichello/godot image, pin it (should be better for security).
  • Sets display/high_res=true so that the game looks sharper on Mac.
  • Sets application/identifier="org.ohmygit" since without it Godot locally complained when trying to export.

Looking through the open issues I believe this PR contributes in the following ways:

run: |
mkdir -p ~/.local/share/godot/templates
mv /root/.local/share/godot/templates/$GODOT_VERSION.stable ~/.local/share/godot/templates/$GODOT_VERSION.stable
mv /root/.local/share/godot/export_templates/$GODOT_VERSION.stable ~/.local/share/godot/templates/$GODOT_VERSION.stable

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This path just changed between 3.2 and 3.6 changed it since else it didn't work.

runs-on: ubuntu-22.04
container:
image: barichello/godot-ci:3.2.3
image: barichello/godot-ci@sha256:026e1f652dd1d718073bb5c32372b3a5d73e7ad7bfe13b9052423604fca6918f

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tobias-wilfert

Copy link
Copy Markdown
Author

@blinry If you have some time to look at this, that would be amazing. Happy to discuss any of the changes / address any feedback.

@tobias-wilfert

Copy link
Copy Markdown
Author

Also while looking through the existing Mac related problems found #176 which I think could be an easy follow up to this (didn't want to cram it into this PR).

@tobias-wilfert

Copy link
Copy Markdown
Author

lol butter fingers 👍🏻

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant