Repository navigation
Document using proxy in Docker builds - #627
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
simonchrz
reviewed
Oct 28, 2026
simonchrz
left a comment
Contributor
There was a problem hiding this comment.
Checked the guide against main: flags, /npm/ and /gem/ paths, proxy_cache_hits_total, audit passthrough, the docker.io mirror via ns, and the pull-only OCI note all match. The example command also works from an empty directory since the database and storage directories are created on startup.
A few small optional points:
- Bundler only falls back to the original source when
mirror.https://rubygems.org.fallback_timeoutis set. Without it,bundle installfails if the proxy is unreachable. Might be worth naming the setting in that sentence. - If
--build-arg PROXY_URLis forgotten, npm gets--registry=/npm/and fails with an unclear error."${PROXY_URL:?PROXY_URL build arg required}"in theRUNlines would make that obvious. - The Bundler mirror setting isn't kept in the image, but the proxy URL still shows up in
docker historybecauseRUNlines are recorded with build args. Only matters if the URL contains credentials. npm ci --no-audit --no-fundwould avoid the upstream audit requests mentioned in the npm section.
simonchrz
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a Docker build guide with npm and Bundler examples, persistent proxy storage, local and CI networking, and BuildKit registry mirrors for base images. Explain how the shared package cache works alongside layer caches and cache mounts, including the pull-only OCI endpoint's limitation for registry-cache exports.
Link the guide from the README's quick start.