Skip to content

Commit 6c5c2da

Browse files
refactor: rename test resources for clarity and add unparam lint suppressions to test helpers
1 parent 66ce2c5 commit 6c5c2da

2 files changed

Lines changed: 6 additions & 6 deletions

File tree

‎internal/controller/tenantquota_controller_test.go‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -310,23 +310,23 @@ var _ = Describe("TenantQuota Controller", func() {
310310
})
311311

312312
It("defaults rollout.strategy to Recreate when omitted", func() {
313-
tq := makeTQ("tq-strat-def", tqNS, 6, 0, 12, 6)
313+
tq := makeTQ("tq-strategy-def", tqNS, 6, 0, 12, 6)
314314
Expect(k8sClient.Create(ctx, tq)).To(Succeed())
315315

316-
ad := makeBasicAD("ad-strat-def", tqNS, "tq-strat-def", 2)
316+
ad := makeBasicAD("ad-strategy-def", tqNS, "tq-strategy-def", 2)
317317
ad.Spec.Rollout.Strategy = ""
318318
Expect(k8sClient.Create(ctx, ad)).To(Succeed())
319319

320320
fetched := &agentraxv1alpha1.AgentDeployment{}
321-
Expect(k8sClient.Get(ctx, namespacedName("ad-strat-def", tqNS), fetched)).To(Succeed())
321+
Expect(k8sClient.Get(ctx, namespacedName("ad-strategy-def", tqNS), fetched)).To(Succeed())
322322
Expect(fetched.Spec.Rollout.Strategy).To(Equal("Recreate"))
323323
})
324324
})
325325
})
326326

327327
// ── Test helpers ──────────────────────────────────────────────────────────────
328328

329-
func makeTQ(name, ns string, maxAgents, maxGPUs, maxTotalReplicas, maxReplicasPerAgent int32) *agentraxv1alpha1.TenantQuota {
329+
func makeTQ(name, ns string, maxAgents, maxGPUs, maxTotalReplicas, maxReplicasPerAgent int32) *agentraxv1alpha1.TenantQuota { //nolint:unparam
330330
return &agentraxv1alpha1.TenantQuota{
331331
ObjectMeta: metav1.ObjectMeta{Name: name, Namespace: ns},
332332
Spec: agentraxv1alpha1.TenantQuotaSpec{
@@ -340,7 +340,7 @@ func makeTQ(name, ns string, maxAgents, maxGPUs, maxTotalReplicas, maxReplicasPe
340340

341341
// makeBasicAD builds a minimal AgentDeployment suitable for TQ reconciler tests.
342342
// It uses a real image name that won't pull (but pod scheduling isn't needed here).
343-
func makeBasicAD(name, ns, tenantRef string, maxReplicas int32) *agentraxv1alpha1.AgentDeployment {
343+
func makeBasicAD(name, ns, tenantRef string, maxReplicas int32) *agentraxv1alpha1.AgentDeployment { //nolint:unparam
344344
return &agentraxv1alpha1.AgentDeployment{
345345
ObjectMeta: metav1.ObjectMeta{Name: name, Namespace: ns},
346346
Spec: agentraxv1alpha1.AgentDeploymentSpec{

‎internal/controller/test_helpers_test.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ const (
3333
)
3434

3535
// namespacedName is a convenience wrapper for building types.NamespacedName.
36-
func namespacedName(name, namespace string) types.NamespacedName {
36+
func namespacedName(name, namespace string) types.NamespacedName { //nolint:unparam
3737
return types.NamespacedName{Name: name, Namespace: namespace}
3838
}
3939

0 commit comments

Comments
 (0)