Skip to content

Commit 14c568a

Browse files
authored
Merge pull request #4128 from github/mbg/move-changetool
Migrate `changetool` to `pr-checks`
2 parents 5584cec + 0484c3a commit 14c568a

12 files changed

Lines changed: 39 additions & 517 deletions

File tree

‎.github/workflows/pr-checks.yml‎

Lines changed: 4 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ jobs:
4545
uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0
4646
with:
4747
node-version: ${{ matrix.node-version }}
48-
cache: 'npm'
48+
cache: "npm"
4949

5050
- name: Install dependencies
5151
run: |
@@ -77,33 +77,6 @@ jobs:
7777
sarif_file: eslint.sarif
7878
category: eslint
7979

80-
changetool-tests:
81-
name: changetool unit tests
82-
permissions:
83-
contents: read
84-
runs-on: ubuntu-slim
85-
timeout-minutes: 10
86-
87-
concurrency:
88-
cancel-in-progress: ${{ github.event_name == 'pull_request' || false }}
89-
group: pr-checks-changetool-tests-${{ github.ref }}-${{ github.event_name }}
90-
91-
steps:
92-
- name: Checkout repository
93-
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
94-
95-
- name: Set up Node.js
96-
uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0
97-
with:
98-
node-version: 24
99-
cache: 'npm'
100-
101-
- name: Install dependencies
102-
run: npm ci
103-
104-
- name: Run changetool unit tests
105-
run: npm --workspace changetool test
106-
10780
# These checks do not need to be run as part of the same matrix that we use for the `unit-tests`
10881
# job.
10982
other-checks:
@@ -126,7 +99,7 @@ jobs:
12699
uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0
127100
with:
128101
node-version: 24
129-
cache: 'npm'
102+
cache: "npm"
130103

131104
- name: Install dependencies
132105
id: install-deps
@@ -190,14 +163,14 @@ jobs:
190163
path: ${{ runner.temp }}/repo-size/
191164
if-no-files-found: error
192165

193-
- name: 'Backport: Check out base ref'
166+
- name: "Backport: Check out base ref"
194167
id: checkout-base
195168
if: ${{ startsWith(github.head_ref, 'backport-') }}
196169
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
197170
with:
198171
ref: ${{ github.base_ref }}
199172

200-
- name: 'Backport: Verify Node versions unchanged'
173+
- name: "Backport: Verify Node versions unchanged"
201174
if: steps.checkout-base.outcome == 'success'
202175
env:
203176
HEAD_VERSION: ${{ steps.head-version.outputs.node_version }}

‎eslint.config.mjs‎

Lines changed: 1 addition & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -180,7 +180,7 @@ export default [
180180
},
181181
},
182182
{
183-
files: ["pr-checks/**/*.ts"],
183+
files: ["pr-checks/**/*.ts", "pr-checks/**/*.mts"],
184184

185185
languageOptions: {
186186
parserOptions: {
@@ -209,18 +209,4 @@ export default [
209209
],
210210
},
211211
},
212-
{
213-
files: ["scripts/changetool/**/*.ts"],
214-
215-
languageOptions: {
216-
parserOptions: {
217-
project: "./scripts/changetool/tsconfig.json",
218-
},
219-
},
220-
221-
rules: {
222-
"no-console": "off",
223-
"import/extensions": "off",
224-
},
225-
},
226212
];

0 commit comments

Comments
 (0)