Skip to content

Commit 5bb3554

Browse files
committed
Make input-validation assertions more granular
1 parent 87cac24 commit 5bb3554

2 files changed

Lines changed: 8 additions & 4 deletions

File tree

‎pr-checks/post-comment.test.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,14 +64,14 @@ describe("parseOptions", async () => {
6464
await it("rejects an empty --marker", () => {
6565
assert.throws(
6666
() => parseOptions(withFlag("--marker", "")),
67-
/Missing required flag --marker/,
67+
/The value for --marker cannot be empty/,
6868
);
6969
});
7070

7171
await it("rejects a whitespace-only --marker", () => {
7272
assert.throws(
7373
() => parseOptions(withFlag("--marker", " \t\n")),
74-
/Missing required flag --marker/,
74+
/The value for --marker cannot be empty/,
7575
);
7676
});
7777
});

‎pr-checks/post-comment.ts‎

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,12 +46,16 @@ export function parseOptions(argv?: string[]): Options {
4646
strict: true,
4747
});
4848

49-
assert(values.marker?.trim(), "Missing required flag --marker.");
49+
assert(values.marker !== undefined, "Missing required flag --marker.");
50+
assert(
51+
values.marker.trim() !== "",
52+
"The value for --marker cannot be empty.",
53+
);
5054
const [owner, repo] = values.repository!.split("/");
5155

5256
return {
5357
body: values.body!,
54-
marker: values.marker!,
58+
marker: values.marker,
5559
issueId: Number(values["issue-id"]),
5660
repository: { owner, repo },
5761
};

0 commit comments

Comments
 (0)