Skip to content

Commit 6ec2b18

Browse files
henrymercerCopilot
andcommitted
Rename logPerLanguageBundleFallback to logMissingPerLanguageBundle
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
1 parent fa8392b commit 6ec2b18

4 files changed

Lines changed: 11 additions & 11 deletions

File tree

‎lib/entry-points.js‎

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎src/per-language-bundles.ts‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -132,15 +132,15 @@ export async function getPerLanguageBundleLanguage(
132132
return language;
133133
}
134134

135-
/** Explains why an eligible per-language bundle is being replaced by a combined bundle. */
136-
export function logPerLanguageBundleFallback(
135+
/** Logs that the selected per-language bundle is missing, so we're using the combined bundle. */
136+
export function logMissingPerLanguageBundle(
137137
{ logger }: ActionState<["Logger"]>,
138138
language: BuiltInLanguage,
139139
location: string,
140140
): void {
141141
logger.warning(
142-
`No per-language CodeQL bundle for '${language}' was found at ${location}, so ` +
143-
"falling back to the bundle that contains all languages. This analysis will still " +
144-
"produce correct results, but will take longer to set up.",
142+
`Expected a per-language CodeQL bundle for '${language}' at ${location}, but it wasn't ` +
143+
"found, so using the bundle that contains all languages instead. This analysis will " +
144+
"still produce correct results, but will take longer to set up.",
145145
);
146146
}

‎src/setup-codeql.test.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1422,7 +1422,7 @@ for (const bundle of ["per-language", "combined", "fallback"] as const) {
14221422
bundle: { kind: "combined", url: combinedURL },
14231423
});
14241424
checkExpectedLogMessages(t, loggedMessages, [
1425-
`No per-language CodeQL bundle for 'javascript' was found at ${perLanguageURL}`,
1425+
`Expected a per-language CodeQL bundle for 'javascript' at ${perLanguageURL}`,
14261426
]);
14271427
}
14281428
if (bundle === "per-language") {

‎src/setup-codeql.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ import { Logger } from "./logging";
4242
import { getCodeQlVersionsForOverlayBaseDatabases } from "./overlay/caching";
4343
import {
4444
getPerLanguageBundleLanguage,
45-
logPerLanguageBundleFallback,
45+
logMissingPerLanguageBundle,
4646
} from "./per-language-bundles";
4747
import { getBundlePlatform } from "./platform";
4848
import * as tar from "./tar";
@@ -1113,7 +1113,7 @@ export async function downloadCodeQLBundle(
11131113
) {
11141114
throw e;
11151115
}
1116-
logPerLanguageBundleFallback(action, bundle.language, bundle.url);
1116+
logMissingPerLanguageBundle(action, bundle.language, bundle.url);
11171117

11181118
const result = await downloadCodeQL(
11191119
{

0 commit comments

Comments
 (0)