Repository navigation
Update the minimatch copies used by archiver and eslint-plugin-import-x to v11 - #4332
Open
henrymercer wants to merge 3 commits into
Open
henrymercer wants to merge 3 commits into
henrymercer wants to merge 3 commits into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Human or CI validation is needed to confirm that the npm override preserves partial-database archiving behavior across the bundled Node 24 action’s supported execution paths.
No open issues 🎉
1 file not reviewed
lib/entry-points.js: Excluded by your content exclusion settings
What changed in this PR
Updates vulnerable transitive minimatch dependencies to 11.0.8 while preserving the older dependency tree used by @actions/artifact.
Changes:
- Adds a scoped override so
archiver8 usesreaddir-glob4. - Updates lockfile entries for
minimatch,readdir-glob,glob, and related packages. - Leaves the development-only
typescript-eslintcopy for a later upgrade.
| File | Description |
|---|---|
| package.json | Adds a scoped override for archiver 8 to use readdir-glob 4. |
| package-lock.json | Records the updated minimatch 11.0.8 dependency resolutions and related transitive package changes. |
Review effort: Lite (adaptive)
henrymercer
marked this pull request as ready for review
November 19, 2026 14:05
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move two of the three copies of
minimatchaffected by GHSA-g3hv-75wg-m249 to 11.0.8.archiver8.0.0, its latest release, depends onreaddir-glob^3.0.0, which usesminimatchv10.readdir-glob4.0.0 only changes itsminimatchdependency to ^11.0.1 and its minimum Node version to 20, so this overridesarchiver'sreaddir-globto ^4.0.0. The override only applies toarchiverv8, so@actions/artifact'sarchiverv7 keepsreaddir-glob1.1.3, whoseminimatchv5 isn't affected. The onlyarchivermethod we call that reachesreaddir-globisdirectory(), which doesn't give it any patterns, soreaddir-globnever constructs aMinimatch. We can remove the override oncearchivermoves toreaddir-globv4.eslint-plugin-import-x4.18.1 from Bump the npm-minor group across 1 directory with 9 updates #4329 acceptsminimatchv11, sonpm update minimatchmoves its copy to 11.0.8. This also movesglob's copy from 11.0.2, which isn't affected, to 11.0.8, without changing the bundle.The remaining copy comes from
@typescript-eslint/typescript-estree8.72.2, a development dependency.typescript-eslint8.73.0 moves tominimatchv11, and Dependabot should pick it up once its cooldown has passed.Risk assessment
For internal use only. Please select the risk level of this change:
Which use cases does this change impact?
Workflow types:
dynamicworkflows (Default Setup, Code Quality, ...).Products:
analysis-kinds: code-scanning.analysis-kinds: code-quality.upload-sarifaction.Environments:
github.comand/or GitHub Enterprise Cloud with Data Residency.How did/will you validate this change?
pr-checks). The "Debug artifacts after failure" check creates a partial database bundle witharchiver'sdirectory().If something goes wrong after this change is released, what are the mitigation and rollback strategies?
How will you know if something goes wrong after this change is released?
Are there any special considerations for merging or releasing this change?
Merge / deployment checklist