Repository navigation
Conversation
Co-authored-by: edburns <75821+edburns@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The ADR’s earlier platform-scope section still incorrectly describes Linux musl as unsupported and publication as containing only six classifiers.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Adds Java linuxmusl-arm64 native runtime support across packaging, validation, testing, publication, and documentation.
Changes:
- Adds ARM64 musl Maven profiles and host validation.
- Extends CI and publishing pipelines.
- Updates tests and supported-platform documentation.
| File | Description |
|---|---|
java/sdk/pom.xml |
Selects the ARM64 musl runtime. |
java/README.md |
Documents platform support and build commands. |
java/docs/adr/adr-007-native-bundling-strategy.md |
Adds the published classifier to the ADR. |
java/copilot-native/scripts/validate-native-host.test.mjs |
Tests ARM64 musl host acceptance. |
java/copilot-native/scripts/validate-native-host.mjs |
Recognizes the ARM64 musl classifier. |
java/copilot-native/scripts/validate-native-artifact.test.mjs |
Includes the classifier in publication fixtures. |
java/copilot-native/scripts/validate-local-publication.mjs |
Requires the classifier in complete publications. |
java/copilot-native/scripts/fetch-native.test.mjs |
Extends fetch tests to ARM64 musl. |
java/copilot-native/pom.xml |
Packages and attaches the classifier JAR. |
.github/workflows/java-sdk-tests.yml |
Tests and assembles ARM64 musl artifacts. |
.github/workflows/java-publish-snapshot.yml |
Builds and publishes snapshot artifacts. |
.github/workflows/java-publish-maven.yml |
Builds and publishes release artifacts. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| 4. Loads it via [JNA](#references) using the C ABI entry points, per the [binding technology decision](#binding-technology-jna-over-panama-ffm) above. The JNA-specific code is confined behind an internal binding interface to preserve a future FFM migration path. | ||
| * A validated supported-host profile fetches the matching platform tarball from the pinned `github/copilot-cli` release, verifies its release SHA-256, and packages the version-matched runtime files. | ||
| * The current release work publishes the `linux-x64`, `linux-arm64`, `linuxmusl-x64`, `win32-x64`, `win32-arm64`, `darwin-x64`, and `darwin-arm64` classifiers. The planned classifier set expands to the other detected platforms. | ||
| * The current release work publishes the `linux-x64`, `linux-arm64`, `linuxmusl-x64`, `linuxmusl-arm64`, `win32-x64`, `win32-arm64`, `darwin-x64`, and `darwin-arm64` classifiers. The planned classifier set expands to the other detected platforms. |
This comment has been minimized.
This comment has been minimized.
@copilot update the ADR to document what is now actually supported. |
Co-authored-by: edburns <75821+edburns@users.noreply.github.com>
Updated the current platform scope to cover both musl classifiers and the eight-classifier publication flow in commit 0c8c4f7. |
SDK Consistency Review — PR #2728This PR adds a new native-runtime classifier ( Findings:
Conclusion: No cross-SDK consistency issues found. This PR is an internal Java build/packaging enhancement and does not require corresponding changes in other language SDKs.
|
|
Closing as already implemented by the normal SDK snapshot in 20d75a71, included in the published SDK v1.0.17. The Java native packaging profiles, SDK profile, ARM64 musl host/artifact validation, and external classifier attachment already support linuxmusl-arm64; current documentation also lists that classifier. The native module POM and several validation files on main exactly match this PR's results. No separate merge is needed. Thanks for completing the platform support. |

Adds Java native runtime packaging, testing, and publishing support for
linuxmusl-arm64, matching the existing native classifier pipeline.Packaging
linuxmusl-arm64artifacts during publication.CI and publishing
ubuntu-24.04-arm.Coverage and documentation
linuxmusl-arm64as a supported in-process platform.linuxmusl-arm64#2727