dead code cleanup

Author: skarim

cmd/submit.go

@@ -46,8 +46,9 @@ This command performs several steps:
   3. Updates base branches for existing PRs
   4. Creates or updates the stack on GitHub
 
-In the editor, new PRs default to ready for review; toggle "Open as draft" per
-PR. With --auto, new PRs are created as drafts unless you pass --open.`,
+In the editor, new PRs default to ready for review; switch any to draft with the
+"CREATE AS" toggle. With --auto, new PRs are created as drafts unless you pass
+--open.`,
 		Example: `  # Push and create/update PRs (opens the interactive editor)
   $ gh stack submit
 
@@ -284,7 +285,6 @@ func collectPRDrafts(cfg *config.Config, client github.ClientOps, s *stack.Stack
 	model := submitview.New(submitview.Options{
 		Nodes:     nodes,
 		Trunk:     s.Trunk,
-		StackName: stackDisplayName(s),
 		RepoLabel: repoLabel,
 		Version:   Version,
 	})
@@ -310,22 +310,6 @@ func collectPRDrafts(cfg *config.Config, client github.ClientOps, s *stack.Stack
 	return submitview.BuildDrafts(m.Nodes()), false, nil
 }
 
-// stackDisplayName returns a human-readable name for the stack, used in the TUI
-// header: the stack prefix, else the common branch-name prefix, else the
-// bottom-most branch.
-func stackDisplayName(s *stack.Stack) string {
-	if s.Prefix != "" {
-		return strings.TrimRight(s.Prefix, "/")
-	}
-	if p := submitview.CommonPrefix(s.BranchNames()); p != "" {
-		return strings.TrimRight(p, "/")
-	}
-	if len(s.Branches) > 0 {
-		return s.Branches[0].Branch
-	}
-	return s.Trunk.Branch
-}
-
 // ensurePR finds or creates a PR for the branch at index i, and updates
 // its base branch if needed. This is the single place where PR state is
 // reconciled during submit.

cmd/submit_tui_test.go

@@ -11,46 +11,6 @@ import (
 	"github.com/stretchr/testify/require"
 )
 
-func TestStackDisplayName(t *testing.T) {
-	tests := []struct {
-		name string
-		s    *stack.Stack
-		want string
-	}{
-		{
-			name: "uses stack prefix",
-			s:    &stack.Stack{Prefix: "feat/", Trunk: stack.BranchRef{Branch: "main"}},
-			want: "feat",
-		},
-		{
-			name: "falls back to common branch prefix",
-			s: &stack.Stack{
-				Trunk:    stack.BranchRef{Branch: "main"},
-				Branches: []stack.BranchRef{{Branch: "feat/auth/a"}, {Branch: "feat/auth/b"}},
-			},
-			want: "feat/auth",
-		},
-		{
-			name: "single branch falls back to its name",
-			s: &stack.Stack{
-				Trunk:    stack.BranchRef{Branch: "main"},
-				Branches: []stack.BranchRef{{Branch: "solo"}},
-			},
-			want: "solo",
-		},
-		{
-			name: "no branches falls back to trunk",
-			s:    &stack.Stack{Trunk: stack.BranchRef{Branch: "main"}},
-			want: "main",
-		},
-	}
-	for _, tt := range tests {
-		t.Run(tt.name, func(t *testing.T) {
-			assert.Equal(t, tt.want, stackDisplayName(tt.s))
-		})
-	}
-}
-
 // TestCollectPRDrafts_SkipsWhenNoNewBranches verifies the TUI is skipped (no
 // program launched) when every branch already has a PR, returning nil drafts so
 // the normal push/relink path runs.

internal/tui/submitview/data.go

@@ -124,7 +124,7 @@ func CountSelected(nodes []SubmitNode) int {
 }
 
 // HasClosed reports whether any branch in the list has a closed PR, which blocks
-// the stack and triggers the Step 1 callout.
+// the stack and triggers the closed-branch callout.
 func HasClosed(nodes []SubmitNode) bool {
 	for _, node := range nodes {
 		if node.State == StateClosed {
@@ -145,63 +145,6 @@ func ClosedBranches(nodes []SubmitNode) []string {
 	return names
 }
 
-// CommonPrefix returns the longest shared slash-delimited path prefix across the
-// given branch names, including a trailing slash. It returns "" when fewer than
-// two names are given or there is no shared prefix. This is used to render the
-// stack map with short branch names.
-func CommonPrefix(names []string) string {
-	if len(names) < 2 {
-		return ""
-	}
-
-	// Split each name into slash-delimited segments and find the longest run of
-	// leading segments common to all names.
-	segs := make([][]string, len(names))
-	minLen := -1
-	for i, n := range names {
-		segs[i] = strings.Split(n, "/")
-		// The last segment is the leaf name; only path segments before it can
-		// be part of a shared prefix.
-		pathLen := len(segs[i]) - 1
-		if minLen == -1 || pathLen < minLen {
-			minLen = pathLen
-		}
-	}
-	if minLen <= 0 {
-		return ""
-	}
-
-	common := 0
-	for i := 0; i < minLen; i++ {
-		seg := segs[0][i]
-		same := true
-		for j := 1; j < len(segs); j++ {
-			if segs[j][i] != seg {
-				same = false
-				break
-			}
-		}
-		if !same {
-			break
-		}
-		common++
-	}
-	if common == 0 {
-		return ""
-	}
-	return strings.Join(segs[0][:common], "/") + "/"
-}
-
-// Shortname strips prefix from branch when present, returning the remainder. If
-// branch does not start with prefix (or prefix is empty), branch is returned
-// unchanged.
-func Shortname(branch, prefix string) string {
-	if prefix == "" {
-		return branch
-	}
-	return strings.TrimPrefix(branch, prefix)
-}
-
 // humanize replaces hyphens and underscores with spaces. It mirrors the helper
 // used by the submit command so auto-generated titles match across paths.
 func humanize(s string) string {

internal/tui/submitview/data_test.go

@@ -199,29 +199,3 @@ func TestClosedBranches(t *testing.T) {
 	}
 	assert.Equal(t, []string{"feat/legacy"}, ClosedBranches(nodes))
 }
-
-func TestCommonPrefix(t *testing.T) {
-	tests := []struct {
-		name  string
-		names []string
-		want  string
-	}{
-		{"shared two-segment prefix", []string{"feat/auth/a", "feat/auth/b", "feat/auth/c"}, "feat/auth/"},
-		{"shared one-segment prefix", []string{"feat/a", "feat/b"}, "feat/"},
-		{"no shared prefix", []string{"feat/a", "fix/b"}, ""},
-		{"single name has no prefix", []string{"feat/a"}, ""},
-		{"empty list", nil, ""},
-		{"flat names share nothing", []string{"a", "b"}, ""},
-	}
-	for _, tt := range tests {
-		t.Run(tt.name, func(t *testing.T) {
-			assert.Equal(t, tt.want, CommonPrefix(tt.names))
-		})
-	}
-}
-
-func TestShortname(t *testing.T) {
-	assert.Equal(t, "middleware", Shortname("feat/auth/middleware", "feat/auth/"))
-	assert.Equal(t, "feat/auth/middleware", Shortname("feat/auth/middleware", ""))
-	assert.Equal(t, "other/x", Shortname("other/x", "feat/auth/"))
-}

internal/tui/submitview/model.go

@@ -42,8 +42,6 @@ type Options struct {
 	Nodes []SubmitNode
 	// Trunk is the stack's trunk branch, shown for context.
 	Trunk stack.BranchRef
-	// StackName is the human-readable stack name shown in the header.
-	StackName string
 	// RepoLabel is the "owner/repo" string shown in the header.
 	RepoLabel string
 	// Version is the CLI version string.
@@ -54,14 +52,9 @@ type Options struct {
 type Model struct {
 	nodes     []SubmitNode
 	trunk     stack.BranchRef
-	stackName string
 	repoLabel string
 	version   string
 
-	// prefix is the common slash-delimited branch-name prefix, used to render
-	// short branch names in the stack map.
-	prefix string
-
 	cursor int // index into nodes (the focused branch)
 
 	width, height int
@@ -85,9 +78,6 @@ type Model struct {
 	statusMessage string
 	statusIsError bool
 
-	// hoverRow is the node index currently under the mouse pointer, or -1.
-	hoverRow int
-
 	// leftScroll is the first visible row offset of the left stack timeline when
 	// its content is taller than the panel.
 	leftScroll int
@@ -115,11 +105,6 @@ type Model struct {
 // opens immediately with the first branch focused (preferring the first NEW
 // branch) and the title field ready for editing.
 func New(opts Options) Model {
-	branchNames := make([]string, len(opts.Nodes))
-	for i, n := range opts.Nodes {
-		branchNames[i] = n.Ref.Branch
-	}
-
 	// Start on the bottom-most NEW branch (closest to trunk) — the first PR
 	// created, in stack order. Nodes are ordered top (index 0) to bottom, so the
 	// bottom-most NEW branch is the highest-indexed one.
@@ -144,12 +129,9 @@ func New(opts Options) Model {
 	m := Model{
 		nodes:     opts.Nodes,
 		trunk:     opts.Trunk,
-		stackName: opts.StackName,
 		repoLabel: opts.RepoLabel,
 		version:   opts.Version,
-		prefix:    CommonPrefix(branchNames),
 		cursor:    cursor,
-		hoverRow:  -1,
 
 		titleInput:   ti,
 		descArea:     ta,

internal/tui/submitview/model_test.go

@@ -52,7 +52,6 @@ func testModel(t *testing.T, nodes []SubmitNode) Model {
 	m := New(Options{
 		Nodes:     nodes,
 		Trunk:     stack.BranchRef{Branch: "main"},
-		StackName: "feat/auth",
 		RepoLabel: "myorg/myrepo",
 		Version:   "1.0.0",
 	})
@@ -88,11 +87,6 @@ func TestNew_AllNewIncludedByDefault(t *testing.T) {
 	assert.True(t, m.nodes[1].Included)
 }
 
-func TestNew_ComputesPrefix(t *testing.T) {
-	m := testModel(t, newNodes())
-	assert.Equal(t, "feat/auth/", m.prefix)
-}
-
 // --- navigation ---
 
 func TestNavigation_MovesAcrossAllBranches(t *testing.T) {
@@ -359,14 +353,6 @@ func TestMouse_ClickCheckboxToggles(t *testing.T) {
 	assert.False(t, m.nodes[0].Included)
 }
 
-func TestMouse_HoverTracksRow(t *testing.T) {
-	m := testModel(t, newNodes())
-	y, _ := leftBranchNode(m, 2)
-	updated, _ := m.Update(tea.MouseMsg{Action: tea.MouseActionMotion, X: 6, Y: y})
-	m = updated.(Model)
-	assert.Equal(t, 2, m.hoverRow)
-}
-
 // leftBranchNode returns the screen Y of branch idx's node line and the X of its
 // right-edge checkbox, using the live left-panel timeline layout (scroll-aware).
 func leftBranchNode(m Model, idx int) (y, checkboxX int) {

internal/tui/submitview/mouse.go

@@ -14,9 +14,6 @@ func (m Model) handleMouse(msg tea.MouseMsg) (tea.Model, tea.Cmd) {
 	}
 
 	switch msg.Action {
-	case tea.MouseActionMotion:
-		m.updateHover(msg.X, msg.Y)
-		return m, nil
 	case tea.MouseActionPress:
 		leftW, _ := m.panelWidths()
 		overLeft := msg.X >= 0 && msg.X < leftW
@@ -299,8 +296,3 @@ func (m *Model) positionDescCursor(visRow, col int) {
 	}
 	m.descArea.SetCursor(m.descArea.LineInfo().StartColumn + col)
 }
-
-// updateHover tracks the branch row under the pointer for hover styling.
-func (m *Model) updateHover(x, y int) {
-	m.hoverRow = m.branchRowAt(x, y)
-}

internal/tui/submitview/styles.go

@@ -46,8 +46,7 @@ func (s BranchState) Label() string {
 // Color returns the foreground color associated with a state.
 func (s BranchState) Color() lipgloss.Color { return stateColors[s] }
 
-// Dot returns the compact legend glyph for a state, used in the Step 2 stack
-// map and legend.
+// Dot returns the compact status glyph for a state.
 func (s BranchState) Dot() string {
 	switch s {
 	case StateNew:

internal/tui/submitview/types.go

@@ -1,8 +1,8 @@
-// Package submitview implements the interactive two-step TUI used by
-// `gh stack submit` to create a stack of pull requests. Step 1 selects which
-// branches without a PR should become PRs; Step 2 is a two-panel editor for
-// drafting each PR's title, description, and draft state before a single
-// batch submit.
+// Package submitview implements the interactive single-screen TUI used by
+// `gh stack submit` to create a stack of pull requests. A left-hand timeline
+// lists the stack and lets the user choose which branches without a PR should
+// become PRs; the right-hand editor drafts each PR's title, description, and
+// ready/draft state before a single batch submit.
 //
 // The package builds on the shared Charm components in internal/tui/shared and
 // reuses the branch display data loaded by internal/tui/stackview. The submit
@@ -15,13 +15,13 @@ import (
 )
 
 // BranchState classifies a branch by the status of its pull request. The state
-// determines whether a branch is selectable in Step 1, editable in Step 2, and
-// which badge color it renders with.
+// determines whether a branch is selectable and editable in the TUI, and which
+// badge color it renders with.
 type BranchState int
 
 const (
 	// StateNew is a branch with no PR yet. It is the only interactive state:
-	// selectable in Step 1 (default on) and editable in Step 2.
+	// selectable (default on) and editable.
 	StateNew BranchState = iota
 	// StateOpen is a branch with an open (non-draft) PR. Locked, shown for context.
 	StateOpen
@@ -36,12 +36,12 @@ const (
 	StateClosed
 )
 
-// Selectable reports whether a branch in this state can be toggled in Step 1.
-// Only NEW branches are selectable.
+// Selectable reports whether a branch in this state can be toggled for
+// inclusion. Only NEW branches are selectable.
 func (s BranchState) Selectable() bool { return s == StateNew }
 
-// Editable reports whether a branch in this state opens the editor in Step 2.
-// Only NEW branches are editable.
+// Editable reports whether a branch in this state opens the editor. Only NEW
+// branches are editable.
 func (s BranchState) Editable() bool { return s == StateNew }
 
 // Locked reports whether a branch is shown for context only (open, draft,