Repository navigation
Replies: 3 comments
|
yes, wanna see a full picture |
|
+1. We split large features into stacks of small pull requests, so each part is easy to read on its own. The authors choose that split, but reviewers would also like the option to see everything together, to get the entire context. The docs make the same point: "Reviewing a single change out of context from the rest of the stack can reduce review quality." Today, the stack map, the stack header and Shift+J / Shift+K make it easy to move between parts, but each part is still read, commented on and approved on its own. The compare view ( As a reviewer, I would like to:
It would work for us if submitting still recorded one review per pull request, so the branch protection and CODEOWNERS approvals that apply to every pull request in a stack keep working as they do today. Similar need has come up elsewhere:
|
Uh oh!
There was an error while loading. Please reload this page.
I'm part of the beta, and it's been great using it so far. My only feedback though is: when someone else creates a stack of PRs, I want to provide review feedback across the whole stack, but the reviews are split entirely per-PR.
It would be great to be able to prepare a review across a full stack, and leave all comments at once. In particular, it would be most useful to:
All reactions