fix(projects): preserve contracts with concrete output envelopes

Restore exact advertised inputs and retain deferred runtime validation. Use concrete method-tagged outputs and keep legacy handler content unchanged. Add empty-page, sequential pagination, backend-error and schema compatibility coverage.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Author: SamMorrowDrums

README.md

@@ -284,7 +284,7 @@ func derefString(s *githubv4.String) string {
 
 // ProjectsList returns the tool and handler for listing GitHub Projects resources.
 func ProjectsList(t translations.TranslationHelperFunc) inventory.ServerTool {
-	tool := NewTool[ProjectsListInput, *ProjectsListOutput](
+	tool := NewToolWithSchemaOptions[ProjectsListInput, *ProjectsListOutput](
 		ToolsetMetadataProjects,
 		mcp.Tool{
 			Name:         "projects_list",
@@ -359,6 +359,7 @@ Use this tool to list projects for a user or organization, or list project field
 			},
 		},
 		scopes.RequireAll(scopes.ReadProject),
+		projectsSchemaOptions(),
 		projectsTypedHandler[ProjectsListInput](func(ctx context.Context, deps ToolDependencies, _ *mcp.CallToolRequest, args map[string]any) (*mcp.CallToolResult, any, error) {
 			method, err := RequiredParam[string](args, "method")
 			if err != nil {
@@ -446,12 +447,12 @@ Use this tool to list projects for a user or organization, or list project field
 		}, decodeProjectsListOutput),
 		normalizeProjectsRouting("list"),
 	)
-	return projectsInputSchema(tool)
+	return tool
 }
 
 // ProjectsGet returns the tool and handler for getting GitHub Projects resources.
 func ProjectsGet(t translations.TranslationHelperFunc) inventory.ServerTool {
-	tool := NewTool[ProjectsGetInput, *ProjectsGetOutput](
+	tool := NewToolWithSchemaOptions[ProjectsGetInput, *ProjectsGetOutput](
 		ToolsetMetadataProjects,
 		mcp.Tool{
 			Name:         "projects_get",
@@ -525,6 +526,7 @@ Use this tool to get details about individual projects, project fields, project
 			},
 		},
 		scopes.RequireAll(scopes.ReadProject),
+		projectsSchemaOptions(),
 		projectsTypedHandler[ProjectsGetInput](func(ctx context.Context, deps ToolDependencies, _ *mcp.CallToolRequest, args map[string]any) (*mcp.CallToolResult, any, error) {
 			method, err := RequiredParam[string](args, "method")
 			if err != nil {
@@ -649,7 +651,7 @@ Use this tool to get details about individual projects, project fields, project
 		}, decodeProjectsGetOutput),
 		normalizeProjectsRouting("get"),
 	)
-	return projectsInputSchema(tool)
+	return tool
 }
 
 func updateProjectItemsItemSchema() *jsonschema.Schema {
@@ -730,7 +732,7 @@ func projectUpdatedFieldSchema() *jsonschema.Schema {
 
 // ProjectsWrite returns the tool and handler for modifying GitHub Projects resources.
 func ProjectsWrite(t translations.TranslationHelperFunc) inventory.ServerTool {
-	tool := NewTool[ProjectsWriteInput, *ProjectsWriteOutput](
+	tool := NewToolWithSchemaOptions[ProjectsWriteInput, *ProjectsWriteOutput](
 		ToolsetMetadataProjects,
 		mcp.Tool{
 			Name:         "projects_write",
@@ -895,6 +897,7 @@ func ProjectsWrite(t translations.TranslationHelperFunc) inventory.ServerTool {
 			},
 		},
 		scopes.RequireAll(scopes.Project),
+		projectsSchemaOptions(),
 		projectsTypedHandler[ProjectsWriteInput](func(ctx context.Context, deps ToolDependencies, _ *mcp.CallToolRequest, args map[string]any) (*mcp.CallToolResult, any, error) {
 			method, err := RequiredParam[string](args, "method")
 			if err != nil {
@@ -1044,7 +1047,7 @@ func ProjectsWrite(t translations.TranslationHelperFunc) inventory.ServerTool {
 		}, decodeProjectsWriteOutput),
 		normalizeProjectsRouting("write"),
 	)
-	return projectsInputSchema(tool)
+	return tool
 }
 
 // Helper functions for consolidated projects tools

pkg/github/__toolsnaps__/projects_get.snap

@@ -36,8 +36,8 @@ func Test_ProjectsList(t *testing.T) {
 	assert.Contains(t, inputSchema.Properties, "project_number")
 	assert.Contains(t, inputSchema.Properties, "query")
 	assert.Contains(t, inputSchema.Properties, "fields")
-	assert.Contains(t, inputSchema.Properties["method"].AnyOf[0].Enum, projectsMethodListProjectViews)
-	assert.Empty(t, inputSchema.Required, "required arguments are checked in legacy order by the handler")
+	assert.Contains(t, inputSchema.Properties["method"].Enum, projectsMethodListProjectViews)
+	assert.ElementsMatch(t, []string{"method", "owner"}, inputSchema.Required)
 }
 
 func Test_ProjectsList_ListProjects(t *testing.T) {
@@ -635,10 +635,10 @@ func Test_ProjectsGet(t *testing.T) {
 	assert.Contains(t, inputSchema.Properties, "owner_type")
 	assert.Contains(t, inputSchema.Properties, "project_number")
 	assert.Contains(t, inputSchema.Properties, "view_id")
-	assert.Contains(t, inputSchema.Properties["method"].AnyOf[0].Enum, projectsMethodGetProjectView)
+	assert.Contains(t, inputSchema.Properties["method"].Enum, projectsMethodGetProjectView)
 	assert.Contains(t, inputSchema.Properties, "field_id")
 	assert.Contains(t, inputSchema.Properties, "item_id")
-	assert.Empty(t, inputSchema.Required, "required arguments are checked in legacy order by the handler")
+	assert.ElementsMatch(t, []string{"method"}, inputSchema.Required)
 }
 
 func Test_ProjectsGet_GetProject(t *testing.T) {
@@ -931,10 +931,10 @@ func Test_ProjectsWrite(t *testing.T) {
 	assert.Contains(t, inputSchema.Properties, "filter")
 	assert.Contains(t, inputSchema.Properties, "visible_fields")
 	assert.Contains(t, inputSchema.Properties, "visible_field_names")
-	assert.Contains(t, inputSchema.Properties["method"].AnyOf[0].Enum, projectsMethodCreateProjectView)
-	assert.Contains(t, inputSchema.Properties["method"].AnyOf[0].Enum, projectsMethodUpdateProjectView)
-	assert.Contains(t, inputSchema.Properties["method"].AnyOf[0].Enum, projectsMethodDeleteProjectView)
-	assert.Empty(t, inputSchema.Required, "required arguments are checked in legacy order by the handler")
+	assert.Contains(t, inputSchema.Properties["method"].Enum, projectsMethodCreateProjectView)
+	assert.Contains(t, inputSchema.Properties["method"].Enum, projectsMethodUpdateProjectView)
+	assert.Contains(t, inputSchema.Properties["method"].Enum, projectsMethodDeleteProjectView)
+	assert.ElementsMatch(t, []string{"method", "owner"}, inputSchema.Required)
 
 	// Verify DestructiveHint is set
 	assert.NotNil(t, toolDef.Tool.Annotations)
@@ -945,7 +945,7 @@ func Test_ProjectsWrite(t *testing.T) {
 func Test_ProjectsWrite_UpdateProjectItemsSchema(t *testing.T) {
 	inputSchema := ProjectsWrite(translations.NullTranslationHelper).Tool.InputSchema.(*jsonschema.Schema)
 	assert.Contains(t, inputSchema.Properties["items"].Description, "prefer it over calling 'update_project_item' in a loop")
-	itemSchema := inputSchema.Properties["items"].AnyOf[0].Items
+	itemSchema := inputSchema.Properties["items"].Items
 
 	assert.Equal(t, "object", itemSchema.Type)
 	assert.Empty(t, itemSchema.Properties, "item references should be modeled by oneOf, not flattened properties")
@@ -977,7 +977,7 @@ func Test_ProjectsWrite_UpdateProjectItemsSchema(t *testing.T) {
 		assert.NotNil(t, variant.AdditionalProperties.Not, "variant must reject additional properties")
 	}
 
-	fieldSchema := inputSchema.Properties["updated_field"].AnyOf[0]
+	fieldSchema := inputSchema.Properties["updated_field"]
 	assert.Equal(t, "object", fieldSchema.Type)
 	assert.Contains(t, fieldSchema.Description, "one top-level field/value applies to every item")
 	require.Len(t, fieldSchema.OneOf, 2)