Skip to content

Commit b632382

Browse files
test(issues): make int64 overflow assertion platform independent
arm64 saturates float64->int64 conversion, so the legacy round-trip check does not report 'too large' for 2^63 on macOS runners. Assert on the parameter name, which appears in the error on every platform. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
1 parent e0638ac commit b632382

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

‎pkg/github/typed_granular_issue_outputs_test.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -322,7 +322,7 @@ func TestTypedGranularIssueWireErrors(t *testing.T) {
322322
{"add_issue_reaction", map[string]any{"content": "HEART"}, "heart"},
323323
{"remove_issue_reaction", map[string]any{"reaction_id": "1.5"}, "non-integer"},
324324
{"add_issue_comment_reaction", map[string]any{"comment_id": 42, "content": "invalid"}, "heart"},
325-
{"remove_issue_comment_reaction", map[string]any{"comment_id": "9223372036854775808", "reaction_id": 9}, "too large"},
325+
{"remove_issue_comment_reaction", map[string]any{"comment_id": "9223372036854775808", "reaction_id": 9}, "comment_id"},
326326
}
327327

328328
testGranularNullResponses := func(t *testing.T) {

0 commit comments

Comments
 (0)