Repository navigation
Commit c047a05
fix(sdk): read legacy Role/Owns charter sections for capability advertisement (#2381)
* fix(sdk): read legacy Role/Owns charter sections for capability advertisement
Motivation: charterEvidence() only consulted the description, expertise,
capabilities, the "What I Own" section and the "I handle" boundary.
Charters written with legacy "## Role" / "## Owns" sections (which
parseAgentDoc retains in extraSections) contributed no evidence, so
declared implementers and reviewers were advertised as advisory-only
with "write and modify code" / "review code" listed as absent.
Approach: include the retained "Owns" and "Role" extra sections in the
charter evidence alongside "What I Own". Existing edit-negation handling (positiveEditEvidence) applies unchanged, so negated
edit claims do not grant edit authority; negated review claims are not handled
(a pre-existing limitation that also applies to "What I Own"). Only the charter half of the report is
addressed; the "## Domain -> Agent" routing-table form in the Ralph
triage parser is left alone, as accepting it changes shared triage
behaviour and merits a separate decision.
Validation: added two tests in test/team-capabilities.test.ts (legacy
sections yield edit/review authority; negated legacy Role stays
advisory). Ran `npx vitest run test/team-capabilities.test.ts`: the
legacy-section test fails without the source change and all 47 pass with
it. `npx tsc --noEmit -p packages/squad-sdk` is clean. The repo-wide
`npm run lint` shows unresolved squad-sdk imports in squad-cli because
the SDK is not built here; I did not build the full tree or run the
whole test suite.
Partially addresses the report: https://github.com/bradygaster/squad/issues/2366
Signed-off-by: Pujitha Paladugu <10557236+pujitha24@users.noreply.github.com>
Assisted-by: claude-sonnet-5-5 (via Claude Code)
* test(sdk): isolate legacy charter section coverage
Part of #2366
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
---------
Signed-off-by: Pujitha Paladugu <10557236+pujitha24@users.noreply.github.com>
Co-authored-by: Pujitha Paladugu <10557236+pujitha24@users.noreply.github.com>
Co-authored-by: brady gaster <bradygaster@github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>1 parent cb7be10 commit c047a05
3 files changed
Lines changed: 50 additions & 1 deletion
File tree
- .changeset
- packages/squad-sdk/src/config
- test
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
301 | 301 | | |
302 | 302 | | |
303 | 303 | | |
304 | | - | |
| 304 | + | |
| 305 | + | |
| 306 | + | |
| 307 | + | |
| 308 | + | |
| 309 | + | |
| 310 | + | |
| 311 | + | |
| 312 | + | |
305 | 313 | | |
306 | 314 | | |
307 | 315 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
612 | 612 | | |
613 | 613 | | |
614 | 614 | | |
| 615 | + | |
| 616 | + | |
| 617 | + | |
| 618 | + | |
| 619 | + | |
| 620 | + | |
| 621 | + | |
| 622 | + | |
| 623 | + | |
| 624 | + | |
| 625 | + | |
| 626 | + | |
| 627 | + | |
| 628 | + | |
| 629 | + | |
| 630 | + | |
| 631 | + | |
| 632 | + | |
| 633 | + | |
| 634 | + | |
| 635 | + | |
| 636 | + | |
| 637 | + | |
| 638 | + | |
| 639 | + | |
| 640 | + | |
| 641 | + | |
| 642 | + | |
| 643 | + | |
| 644 | + | |
| 645 | + | |
| 646 | + | |
| 647 | + | |
| 648 | + | |
| 649 | + | |
| 650 | + | |
0 commit comments