Run the SonarQube Cloud analysis on the newest Python leg, not the middle one - #41
Merged
Merged
Conversation
…ddle one The coverage report and Sonar scan have never depended on which matrix leg produces them, and nothing in this file or CLAUDE.md ever justified picking 3.12 specifically -- it was the middle of three versions when the scan was folded into the test job (2df3c86), with no comment tying it to anything version-specific. Anchoring it to matrix.python-version == '3.13' instead means a future Python bump (adding 3.14, eventually dropping 3.11) never requires touching this condition to keep the scan off a version that is about to age out -- the newest supported leg is always the one furthest from that problem. The audit job's separate python-version: "3.12" (pip-audit, unrelated to the test matrix or coverage) is untouched. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The coverage report and Sonar scan don't depend on which matrix leg produces them, and nothing in
ci.ymlorCLAUDE.mdever justified picking 3.12 specifically — it was just the middle of three versions when the scan was folded into the test job.Moved the
if: matrix.python-version == '3.12'conditions (Tests coverage branch, SonarQube step) to'3.13', so future Python bumps (adding 3.14, eventually dropping 3.11) never require touching this to keep the scan off a version about to age out — the newest supported leg is always furthest from that.The
auditjob's separatepython-version: "3.12"(pip-audit, unrelated to the matrix/coverage) is untouched.No functional change to what's checked;
make checkpasses.