This repository was archived by the owner on Oct 19, 2026. It is now read-only.
Repository navigation
Fix: Switch code highlighting theme to min-light/min-dark #1815
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -144,7 +144,7 @@ const CodeContent = ({ | |||||
| setIsShikiLoading(true) | ||||||
| codeToTokens(fileContent, { | ||||||
| lang: detectedLanguage as any, | ||||||
| theme: 'github-light' | ||||||
| theme: 'min-light' | ||||||
| }) | ||||||
| .then((result) => { | ||||||
| if (!cancelled) { | ||||||
|
|
@@ -405,7 +405,7 @@ const CodeContent = ({ | |||||
| try { | ||||||
| const result = await codeToTokens(blockContent, { | ||||||
| lang: detectedLanguage as any, | ||||||
| theme: 'github-light' | ||||||
| theme: 'min-light' | ||||||
|
||||||
| theme: 'min-light' | |
| theme: { dark: 'min-dark', light: 'min-light' } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The theme is hardcoded to 'min-light' without dark mode support. While FileDiff.tsx and BlobEditor.tsx properly use theme objects with both light and dark variants (e.g.,
{ dark: 'min-dark', light: 'min-light' }), this component only uses the light theme. This creates an inconsistent user experience where code highlighting won't respond to dark mode preferences.