Repository navigation
Conversation
cjc0013
marked this pull request as ready for review
October 15, 2026 13:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request partially addresses #495.
It changes the following:
~/.ssh/id_ed25519,~/.ssh/id_ecdsa, then~/.ssh/id_rsa.pubfile to libgit2 when one exists, while preserving private-key fallback when it does notThis mirrors OpenSSH’s default behavior, which tries the agent and then the standard identity files.
The branch base already enables the
git2dependency'ssshfeature (the prerequisite addressed by #3009).Scope
~/.ssh/config, includingIdentityFile, host aliases, or configuredPortvalues. An explicit port in an SSH URL remains handled by the existing transport path.Validation:
cargo build --locked -p asyncgit— passedcargo test --locked -p asyncgit— passed (0 failures).pubfilesrustfmt --edition 2021 --check asyncgit/src/sync/cred.rs asyncgit/src/sync/remotes/callbacks.rs— passedmake check— passed, including workspace clippy, nextest, TOML formatting, and dependency-policy checksgit diff --cached --check— passedsshd— the exact unpatched head failed; the patched tree succeeded and fetched the expected ref using a throwaway~/.ssh/id_ed25519I followed the checklist:
make checkwithout errorsPrior work and attribution
No code was copied from issue comments or prior pull requests.
Issue-discussion provenance (not authorship or implementation attribution)
For provenance only, the issue thread also contains reports, reproductions, environment details, questions, or confirmations from: 52617365, a-essawy, Abraxos, AllenDang, apraga, aragalie, austinbutler, ayuayue, brendon-at-rea, burgessa23, ccalvarez, cd-a, cz2415, Diablo-D3, dmytro-tolkodubov, DreckSallow, eggcaker, FBen3, fgimian, frixaco, grv07, heliostatic, jamesb93, JSilva6, kyruzic, leechdraw, Martan404, matthewp, MiragianCycle, nik-rev, non-descriptive, parrotdance, psuong, RilDev, rokrdev, rootex-, Sammmmm, ser-art, ser-drephs, staszewski, tmpgnh, Tony1324, tyoc213, vagra, VictorKoenders, vtvz, xanderificnl, Zeonova, Zhoujinpeng1999.
This list is not authorship or implementation credit, and no code from these participants was copied into this change.