Skip to content

Fix IPv6 Docker remote source URLs - #1064

Open
cuishuang wants to merge 1 commit into
glanceapp:devfrom
cuishuang:dev
Open

Fix IPv6 Docker remote source URLs#1064
cuishuang wants to merge 1 commit into
glanceapp:devfrom
cuishuang:dev

Conversation

@cuishuang

Copy link
Copy Markdown

Summary

  • construct remote Docker endpoint addresses with net.JoinHostPort
  • ensure IPv6 literals retain the brackets required by URL syntax
  • add regression tests covering IPv4, hostname, and IPv6 Docker sources

Previously, a source such as tcp://[::1]:2375 was converted to http://::1:2375, which is not a valid URL. It is now converted to http://[::1]:2375.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant