Fix CI: commit git-ignored pure-bindgen tool source - #2
Merged
Conversation
The .NET-output ignore rule '**/bin/' also swallowed Rust's crate-binary source dir crates/ffi/src/bin/, so crates/ffi/src/bin/pure-bindgen.rs was never committed. CI's fresh checkout then failed to parse the ffi manifest (the [[bin]] source was missing), breaking the 'test' and 'bindings' jobs even though local builds — with the file present — were green. Negate the rule for **/src/bin/ so Rust bin sources are tracked while .NET bin/obj stay ignored, and add the missing tool source.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
**/bin/.NET-output ignore rule also swallowed Rust'scrates/ffi/src/bin/,so the
pure-bindgentool source was never committed. CI's fresh checkoutcouldn't parse the ffi manifest (missing
[[bin]]source), failing thetestand
bindingsjobs — while local builds (file present on disk) stayed green.Negates the ignore for
**/src/bin/and commits the missing source.🤖 Generated with Claude Code