The bookmark chips name their passage, the toast waits to be read (v0.61.3) - #47
Merged
Merged
Conversation
….61.3) - Bookmark chips (web): icon + passage — sun beside "Psalms 23:4", flag beside "Genesis 30–31" (what is left of today). The icon-only chips of 0.61.1 said WHICH bookmark but not WHERE, and where is the reason to tap. The kind's name stays on aria-label/title and the tap's toast. Full TOC book names: there is no abbreviation table in the core or the catalogues, and a TypeScript one would be a second copy of 66 names in three languages. - Toast audit (web), six findings, all fixed. The flash: showToast armed a new timer without disarming the last, so a toast raised inside another's 2.2 s was cleared by the PREVIOUS timer. Now one at a time, the newest wins its whole stay; the stay is sized to the message (1.2 s + 60 ms a character, floor 2.5 s, cap 7 s — a flat 2.2 s fitted "Copied" and lost the backup's file name); a 150 ms fade in and out (none under prefers-reduced-motion); it sits above the bottom bar and the home indicator (`max(--bottomNavH, --safeBottom) + 22px` — it was ON the bar on a phone; the sticky notices share the variable and move with it); z 65 so "Link copied" shows over Present (behind it at 50); a max-width so a sentence wraps inside the screen. Android's system Toast already behaves this way — no change there. - E2e: toast.spec.ts (four tests) and bookmarks.spec.ts updated; all five mutations verified red against rebuilt bundles. Manifest: the bookmarks section rewritten; a new "Toasts — the passing confirmation" section carries the contract for both shells. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"Genesis 30–31" (what is left of today). The icon-only chips of 0.61.1 said
WHICH bookmark but not WHERE, and where is the reason to tap. The kind's name
stays on aria-label/title and the tap's toast. Full TOC book names: there is
no abbreviation table in the core or the catalogues, and a TypeScript one
would be a second copy of 66 names in three languages.
timer without disarming the last, so a toast raised inside another's 2.2 s
was cleared by the PREVIOUS timer. Now one at a time, the newest wins its
whole stay; the stay is sized to the message (1.2 s + 60 ms a character,
floor 2.5 s, cap 7 s — a flat 2.2 s fitted "Copied" and lost the backup's
file name); a 150 ms fade in and out (none under prefers-reduced-motion); it
sits above the bottom bar and the home indicator (
max(--bottomNavH, --safeBottom) + 22px— it was ON the bar on a phone; the sticky noticesshare the variable and move with it); z 65 so "Link copied" shows over
Present (behind it at 50); a max-width so a sentence wraps inside the screen.
Android's system Toast already behaves this way — no change there.
mutations verified red against rebuilt bundles. Manifest: the bookmarks
section rewritten; a new "Toasts — the passing confirmation" section carries
the contract for both shells.
🤖 Generated with Claude Code