fix(javascript): reject malformed date strings

Author: schani

packages/quicktype-core/src/language/JavaScript/JavaScriptRenderer.ts

@@ -445,10 +445,15 @@ ${hasArrayConstraints ? '        if ((typ.min !== undefined && val.length < typ.
         if (val === null) {
             return null;
         }
+        if (!(val instanceof Date) && (typeof val !== "string" || !/^[0-9]{4}-(?:0[1-9]|1[0-2])-(?:[0-2][0-9]|3[01])(?:T(?:[01][0-9]|2[0-3]):[0-5][0-9]:[0-5][0-9](?:[.][0-9]+)?(?:Z|[+-](?:[01][0-9]|2[0-3]):[0-5][0-9]))?$/i.test(val)))
+            return invalidValue(l("Date"), val, key, parent);
         const d = new Date(val);
         if (isNaN(d.valueOf())) {
             return invalidValue(l("Date"), val, key, parent);
         }
+        const date = typeof val === "string" ? val.slice(0, 10) : null;
+        if (date !== null && new Date(date + "T00:00:00Z").toISOString().slice(0, 10) !== date)
+            return invalidValue(l("Date"), val, key, parent);
         return d;
     }
 

packages/quicktype-core/src/language/JavaScriptPropTypes/JavaScriptPropTypesRenderer.ts

@@ -209,7 +209,7 @@ export class JavaScriptPropTypesRenderer extends ConvenienceRenderer {
                     return '(props, name) => props[name] == null || /^[0-9a-f]{8}-(?:[0-9a-f]{4}-){3}[0-9a-f]{12}$/i.test(props[name]) ? null : new Error("Expected UUID")';
                 }
                 if (transformedStringType.kind === "date-time") {
-                    return '(props, name) => props[name] == null || typeof props[name] === "string" && !Number.isNaN(Date.parse(props[name])) ? null : new Error("Expected date-time")';
+                    return '(props, name) => { const value = props[name]; if (value == null) return null; const match = typeof value === "string" && /^(\\d{4}-(?:0[1-9]|1[0-2])-(?:[0-2]\\d|3[01]))(?:T(?:[01]\\d|2[0-3]):[0-5]\\d:[0-5]\\d(?:\\.\\d+)?(?:Z|[+-](?:[01]\\d|2[0-3]):[0-5]\\d))?$/i.exec(value); if (match) { const parsed = Date.parse(`${match[1]}T00:00:00Z`); if (!Number.isNaN(parsed) && new Date(parsed).toISOString().slice(0, 10) === match[1]) return null; } return new Error("Expected date-time"); }';
                 }
                 return "PropTypes.string";
             },

test/inputs/schema/date-time.9.fail.date-time.json

@@ -0,0 +1,7 @@
+{
+  "date": "1985-04-12",
+  "time": "23:20:50.52Z",
+  "date-time": "2023-02-29T12:00:00Z",
+  "union-array": ["1985-04-12", "23:20:50.52Z"],
+  "complex-union-array": ["2018-08-13T21:31:01+00:10", "foo", 123]
+}