Skip to content

feat(nav): horizontally scrollable mobile bottom nav #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gnacho merged 1 commit into from
Oct 7, 2026
Merged

feat(nav): horizontally scrollable mobile bottom nav #143

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 23 additions & 8 deletions app/src/components/shell/AppLayout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { useEffect, useState, type MouseEvent, type ReactNode } from 'react';
import { useEffect, useRef, useState, type MouseEvent, type ReactNode } from 'react';
import { Link, NavLink, useLocation, useNavigate } from 'react-router';
import { flushSync } from 'react-dom';
import { motion } from 'framer-motion';
Expand Down Expand Up @@ -403,7 +403,16 @@ export default function AppLayout({ children }: { children: ReactNode }) {

const titleKey = TITLE_KEYS.find(([re]) => re.test(pathname))?.[1] ?? 'nav.dashboard';
const count = useInverterCount();
const { navItems, chargerOn } = useNavItems();
const { navItems } = useNavItems();
/* Bottom-nav deslizable: centra el tab activo en la fila scrolleable. */
const bottomNavRef = useRef<HTMLDivElement>(null);
useEffect(() => {
const el = bottomNavRef.current;
const activeEl = el?.querySelector('[data-active="true"]');
if (el && activeEl) {
activeEl.scrollIntoView({ inline: 'center', block: 'nearest' });
}
}, [pathname]);
const resolvedTitleKey = titleKey === 'nav.inversores' ? invLabelKey(count) : titleKey;
const lgMargin = collapsed ? 'lg:ml-16' : 'lg:ml-[232px]';

Expand Down Expand Up @@ -466,13 +475,21 @@ export default function AppLayout({ children }: { children: ReactNode }) {
className="[view-transition-name:helios-nav] fixed bottom-0 left-0 right-0 z-50 border-t border-app bg-surface/85 pb-safe backdrop-blur-[16px] md:hidden"
aria-label={t('nav.dashboard')}
>
{/* Sin Ajustes: en móvil el acceso es el avatar del header (→ /ajustes) */}
<div className={cn('grid h-16', chargerOn ? 'grid-cols-5' : 'grid-cols-4')}>
{/* Fila deslizable (keynest #284 / deltos #290 / netpulse #1312):
min-width por tab, scrollbar oculta y auto-scroll al activo. */}
<div ref={bottomNavRef} className="flex h-16 overflow-x-auto [scrollbar-width:none] [&::-webkit-scrollbar]:hidden">
{navItems.map(({ to, labelKey, icon: Icon }) => {
const active = isActive(pathname, to);
const label = t(labelKey === 'nav.inversores' ? invLabelKey(count) : labelKey);
return (
<NavLink key={to} to={to} onClick={handleMobileNav(to)} className="relative flex flex-col items-center justify-center gap-1" aria-label={label}>
<NavLink
key={to}
to={to}
onClick={handleMobileNav(to)}
data-active={active ? 'true' : undefined}
className="relative flex min-w-[64px] flex-1 flex-col items-center justify-center gap-1"
aria-label={label}
>
<motion.span
animate={active ? { scale: [1, 1.15, 1] } : { scale: 1 }}
transition={{ duration: 0.25, type: 'spring', stiffness: 500, damping: 20 }}
Expand All @@ -486,9 +503,7 @@ export default function AppLayout({ children }: { children: ReactNode }) {
);
})}
</div>
</nav>

<HeliosToaster />
</nav> <HeliosToaster />
</div>
);
}
Loading