Repository navigation
fix(charger): uploading a photo no longer blanks the page - #148
Merged
Merged
Conversation
invalidateExtensions() nulled the extensions cache, unmounting the page and the nav until a manual reload. The upload endpoint already persists and re-resolves server-side, so the client now only cache-busts the local <img> via an onUploaded callback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regression from #147: the upload called invalidateExtensions(), which nulled the extensions cache and unmounted the page and the nav until a manual reload. The server already persists and re-resolves, so the client only needs to cache-bust the local![]()
(onUploaded callback).