Repository navigation
feat(mobile): pull-to-refresh to pick up new deploys (#28) - #66
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull-to-refresh on mobile to pick up new deploys without reopening
Ports the
PullToRefreshpattern already shipped in Keynest (issue keynest#79): pulling down from the top of the page reloads the current view, so a
freshly deployed build is picked up without closing and reopening the app.
window.scrollY <= 0and the gesture is a verticalpull from the top (does not interfere with native overscroll or the app's
own scrollable lists).
<main>content inAppLayout.Verified with Playwright on a mobile viewport (390x844, real touch via CDP):
short pull does not reload, long pull reloads; 0 page errors.
Closes #28