Repository navigation
fix(topology): stop duplicated hypervisor CT chips (slice aliasing + PVE dedup + guest pinning) - #1379
Merged
Conversation
Two duplication paths for Proxmox guest chips: - Server: applyPVEInfra emitted the hypervisor distnode once per inventory key, and two keys can resolve to the same host (repeated IP or IP+name match), so citadel-02's distnode (and its CT grid) went out twice. Mark the host as emitted inside the loop. - Frontend lock-layout: a CT with its own saved position and a host without a seed was painted twice (host-derived grid chip + pinned seed). Hypervisor guests now never pin by their own seed; they always follow the host grid. References #1378
… element (#1378) The real cause of the duplicated hypervisor CTs: the #1374 absorption filtered dists in place (kept := dists[:0]), rewriting the shared backing array while the caller kept its original length - the last element (dist-pve-default-citadel-02) showed up twice in the overview, and the frontend drew that host's CT grid twice. - Absorption now builds a fresh kept slice and exposes the absorbed ids via TopoSemantics.AbsorbedDists. - live.go filters its distNodes with a fresh slice using those ids. - Test asserts the caller's slice stays intact. The PVE-side hardening and the frontend no-pin-for-guests fix from the previous commit stay (both real, but neither was the cause).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug (#1378)
On the topology map, a Proxmox host's CT/VM chips rendered duplicated, and during drags guests appeared stuck with ghost copies until the layout was saved.
Root causes (three, two benign-looking but real)
distsin place (kept := dists[:0]), rewriting the shared backing array while the caller kept its original length. The last element (dist-pve-default-citadel-02) appeared twice in/api/overview#distributionNodes, and the frontend drew that host's CT grid twice (verified live: two identical distnodes in the API, two chip copies in the DOM).Verification
TopoSemantics.AbsorbedDists;live.gofilters with a fresh slice.Closes #1378