Repository navigation
fix(ports): show WAN tooltip only on the gateway unit - #1386
Merged
Merged
Conversation
The Ports card fed every "wan" jack with the global useNetPulse().wan, which is the internet connection of the gateway unit. Any non-gateway router with a wan jack (e.g. a dumb AP uplinked through its ex-WAN port) showed the gateway's public IP and DNS on a local link. Pass the WAN info to the jack only when the router is the gateway (roleBadge Principal); other units render the jack as a plain port. Closes #1383
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug (#1383)\n\nThe Ports card fed every "wan" jack with the global useNetPulse().wan, which is the internet connection of the gateway unit. Any non-gateway router with a wan jack (e.g. a dumb AP uplinked through its ex-WAN port) showed the gateway's public IP and DNS on what is a local link.\n\n## Fix\n\nPass the WAN info to the jack only when the router is the gateway (roleBadge Principal); other units render the jack as a plain port.\n\n## Verification\n\n- Live preview: AP detail shows the ex-WAN jack as a plain port (no public IP/DNS); gateway unchanged (PPPoE, public IP, gateway, DNS).\n\nCloses #1383