Repository navigation
feat(topology): full-width legend and links table with ping column - #1387
Merged
Merged
Conversation
…1384) The legend and the links table under the map sat side by side (5/7 cols). Both are now full width and stacked: - Legend: its sections (bands, link styles, status, summary) lay out as one horizontal row of columns at lg; the mobile bottom sheet keeps the stacked layout. - Links table: new ping column showing the destination unit's probed latency. The server already polls router->gateway latency on non-gateway units (and WAN latency on the gateway) but only persisted it to metrics; the overview now exposes it per router as latencyMs. Units without a probe (agent-only/external/SNMP) show -. The WAN row moves its latency from the signal column to the ping column. Closes #1384
…row (#1384) The links section lays out in two columns and the summary line (online clients, VPN peers, active links) spans the full card width at the bottom instead of being a fourth column.
New fillWiredSpeeds mirrors the conservative fillUplinkSpeeds criterion for kind=wired sem links: speed is asserted only when the parent is a directly polled fleet router (gateway or beacon-managed switch like the KP-9000) that measured that EthPort up. Links behind a distnode or a device hub (hypervisor CTs) keep SpeedMbps=0 so the front prints an honest dash. Real fleet: switch16->citadel-01 (lan5) and switch16->beelink-nas (lan8) now carry 2500 Mbps.
…n links table (#1384) The backhauls loop only listed AP uplinks, so the managed-switch uplink (Flint2 <-> KP-9000 at 2.5 Gbps) was in the semantics and on the map but missing from the table; now every non-gateway fleet node (APs + switches) gets its uplink row. No duplication with the dist loop: the switch shadow distnode is absorbed server-side (#1374/#1376). The wired-<host> row now reads the parent-measured sem wired speed (fillWiredSpeeds) before falling back to the controller-sealed device speedMbps.
The links section spans two grid columns so its six samples lay out in three columns (wired/wifi | lldp/inferred | hypervisor/ct grid); the summary row keeps the full width below.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Request (#1384)\n\nThe legend and links table under the map sat side by side (5/7 cols), the managed-switch uplink was missing from the table, and hypervisor cables showed no speed.\n\n## Changes\n\n- Legend: full-width card; sections in one row (bands, link samples in three columns, status) with fixed 50px side padding and column gaps, summary line spanning the full width below. Mobile sheet keeps the stacked layout.\n- Links table: full width, new ping column with the destination unit's probed latency. The server already polled per-router latency but only persisted it to metrics; the overview now exposes it as
latencyMs. A stale-rounded 0 from older agents shows as "<1 ms"; units without a probe show -.\n- Switch uplinks listed: the table now lists the uplink of every non-gateway fleet unit (APs and managed switches), not just APs. This surfaces the gateway <-> switch link (2.5 Gbps) that was on the map but not in the table.\n- Hypervisor cable speed: newfillWiredSpeedsfills wired link speed only when the parent is a directly polled fleet router that measured that port up (same conservative criterion as fillUplinkSpeeds); links behind a distnode or device hub keep an honest dash.\n- Ping parser: ParsePingSummary no longer rounds to integer (sub-ms LAN pings became 0); formatting is the UI's job.\n\n## Verification\n\n- Suite 48/48 incl. new TestFillWiredSpeeds (6 cases) and sub-ms ping case; agent probe suite 10/10; eslint 0; vite build OK.\n- Live preview on the home fleet: legend one row with bottom summary; table shows gateway<->switch at 2.5 Gbps, hypervisors (lan5/lan8) at 2.5 Gbps, WAN ping 7.0 ms, AP pings <1 ms, unprobed units as -.\n\nCloses #1384