Repository navigation
feat(agent): lldpd physical-port binding at install + bridge-only hint - #1392
Merged
Merged
Conversation
#1369) On OpenWrt (verified qualcommax/ipq807x nss-dp; DSA likely affected too) an lldpd bound to the bridge (the stock br-lan config) reports zero neighbors forever: LLDP frames never reach a listener on the bridge master, and topology silently falls back to FDB inference. - install-agent.sh: when lldpd is already installed, ensure it listens on physical ports (lan*,wan via UCI) and restart it. Idempotent: a binding with physical ports is left untouched; lldpd itself is never installed by the script (installing packages stays the admin's call). - Agent probe: with an honest zero-neighbor round plus a bridge-only UCI binding, the payload carries lldp.hint=lldpd-bridge-only. UCI is only queried on empty rounds (no extra fork when neighbors exist). - Server propagates it as router.lldpHint; RouterDetail shows a warning banner with the exact fix (i18n es/en). - Docs: binding requirement next to the agent LLDP section. Closes #1369
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem (#1369)
On OpenWrt (verified on qualcommax/ipq807x with nss-dp; DSA likely affected too), an lldpd bound to the bridge - the stock
br-lanconfig afteropkg install lldpd- reports zero neighbors forever: LLDP frames never reach a listener on the bridge master, and topology silently falls back to FDB inference with no warning anywhere.Changes
lan*,wanvia UCI) and restart it. Idempotent: a binding that already includes physical ports is left untouched. The script never installs lldpd itself - installing packages stays the admin's call.lldp.hint="lldpd-bridge-only". UCI is only queried on empty rounds, so no extra fork when neighbors exist. NewLldpdBridgeOnlyparser with 9 table tests.router.lldpHint(recycled with the cache like the neighbors).RouterDetailshows a warning banner with the exact fix command (i18n es/en).Verification
lan*,wan, so the new block would report "already physical" and touch nothing.Closes #1369