Repository navigation
fix(poller): bound Stop wait so a slow SNMP tick cannot hang shutdown (#481) - #523
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a poller tick is stuck on a slow/hung SNMP or SSH poll, Poller.Stop() waited on the in-flight tick forever, so the systemd stop hung until TimeoutStopSec killed the process.
Stop now waits at most 15s (stopWait) and logs that it gave up; main returns and the process exits with the stuck goroutine. The tick itself already terminates on its own thanks to the gosnmp timeout (5s + 1 retry), so bounded waiting never aborts a poll that would otherwise finish.
Includes two regression tests (blocking adapter): Stop returns promptly on a hung tick, and still waits for a tick that finishes.