Repository navigation
feat(devices): discover wired static-IP hosts via router ARP table (#507) - #524
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The agent already pushes its IPv4 neighbor table (MAC -> IP) every 30s and on wireless events, but the server only used it to fill in the IP of devices already known via wireless/FDB/DHCP.
Now any MAC present in a polled router's ARP table that is not already a known device (wireless candidate, FDB candidate, DHCP lease or device_attrib entry) and not a router/bridge MAC appears as a wired (cable) device, online, with the IP from the ARP table and the RouterID of the router that reported it. Per explicit product decision: IPv4 ARP only (no NDP yet) and no persistence - ARP-only hosts show up while the router has them in its neighbor table and disappear when the entry ages out.
Tests: ARP-only MAC appears as wired online device with its ARP IP and RouterID; bridge/router MAC present in ARP is excluded. Full server suite green.