Skip to content

Added unsafe renderer so it always generates what we tell it to - #128

Draft
777arc wants to merge 1 commit into
masterfrom
unsafe
Draft

Added unsafe renderer so it always generates what we tell it to#128
777arc wants to merge 1 commit into
masterfrom
unsafe

Conversation

@777arc

@777arc 777arc commented Dec 27, 2023

Copy link
Copy Markdown
Member

When I tried generating the pages locally by running hugo I noticed it wasnt including <img src... tags, but instead replacing them with <!-- raw HTML omitted --> and this fixes it, in one of the recent releases this started happening https://discourse.gohugo.io/t/raw-html-getting-omitted-in-0-60-0/22032

@marcusmueller

Copy link
Copy Markdown
Member

I'm not a fan – you can include images with ![…](…), and unlike <img src that will correctly include the resources in the build

@777arc

777arc commented Dec 27, 2023

Copy link
Copy Markdown
Member Author

But then we would have to go through all the old html right?

@marcusmueller

Copy link
Copy Markdown
Member

yes, but my understanding is that without that, the images wouldn't be part of what gets deployed, anyways, right?

@777arc

777arc commented Dec 27, 2023

Copy link
Copy Markdown
Member Author

Only if we were to update hugo, which we don't have to

@marcusmueller

Copy link
Copy Markdown
Member

Only if we were to update hugo, which we don't have to

I don't understand. in the old blog entries, the included images, they never get uploaded to any webserver, because hugo doesn't know how to find them, even if we allow <img tags, right?

By the way, all the local images I can find in a quick scan (``) in <img src= have URLs that start with `https://gnuradio.org/wp-content/uploads/{year}/{month}`; they wouldn't work, anyways, so we'd have to manually fix these URLs anways

@777arc
777arc marked this pull request as draft April 26, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants