Skip to content

Move test utilities out of runtime packages #605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
go-jet merged 1 commit into from
Aug 22, 2026
Merged

Move test utilities out of runtime packages #605

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 2 additions & 13 deletions internal/jet/testutils.go → internal/jet/testutils_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,21 +1,10 @@
package jet

import (
"github.com/stretchr/testify/require"
"strconv"
"testing"
)

var defaultDialect = NewDialect(DialectParams{ // just for tests
AliasQuoteChar: '"',
IdentifierQuoteChar: '"',
ArgumentPlaceholder: func(ord int) string {
return "$" + strconv.Itoa(ord)
},
ArgumentToString: func(value any) (string, bool) {
return "", false
},
})
"github.com/stretchr/testify/require"
)

var (
table1Col1 = IntegerColumn("col1")
Expand Down
12 changes: 12 additions & 0 deletions internal/jet/utils.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,24 @@ package jet

import (
"reflect"
"strconv"
"strings"

"github.com/go-jet/jet/v2/internal/utils/dbidentifier"
"github.com/go-jet/jet/v2/internal/utils/must"
)

var defaultDialect = NewDialect(DialectParams{
AliasQuoteChar: '"',
IdentifierQuoteChar: '"',
ArgumentPlaceholder: func(ord int) string {
return "$" + strconv.Itoa(ord)
},
ArgumentToString: func(value any) (string, bool) {
return "", false
},
})

// SerializeClauseList func
func SerializeClauseList(statement StatementType, clauses []Serializer, out *SQLBuilder) {

Expand Down
Loading