Repository navigation
Conversation
Co-authored-by: fredbi <14262513+fredbi@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
validate.Specandvalidate.AgainstSchemapreviously accepted unboundedallOf/anyOf/oneOf/notnesting, so small untrusted documents could trigger disproportionate CPU and memory usage. This change introduces a fail-fast composition-depth guard with deterministic error locations.Configurable depth limit (safe default)
WithMaxSchemaCompositionDepth(limit int)to schema validation options.256; non-positive values fall back to this default.Shared depth-check implementation
schema_composition_depth.go) that traverses onlyallOf,anyOf,oneOf, andnot.Enforcement at both validation entry points
AgainstSchema/NewSchemaValidator) before deep validator construction.SpecValidator.Validate) as an early pass across schema-bearing locations (definitions, parameters, responses, and path/operation schema slots).Error behavior
schema composition nesting exceeds limit.Regression coverage
AgainstSchema: over-limit fails fast, higher limit succeeds.Spec: deeply nested definition composition fails fast, higher limit succeeds.WithMaxSchemaCompositionDepth.