fix: Fix potential regression issue with failed command outputs

Fix the handling of grouped outputs where a child task failing may
result in the output of the commands of a parent task when that parent
task itself didn't fail. Therefore when running with error_only output,
task should not accidentally output more than a single task's output.

Author: jonathanio

task.go

@@ -452,13 +452,13 @@ func (e *Executor) runCommand(ctx context.Context, t *ast.Task, call *Call, i in
 		if err != nil && timedOut(ctx, timeout) {
 			err = timeout
 		}
-		if taskOut != nil && err != nil {
-			taskOut.failed = true
-		}
 		if cmd.IgnoreError && isCommandFailure(err) {
 			e.Logger.VerboseErrf(logger.Yellow, "task: [%s] task error ignored: %v\n", t.Name(), err)
 			return nil
 		}
+		if taskOut != nil && err != nil {
+			taskOut.failed = true
+		}
 		return err
 	case cmd.Cmd != "":
 		if !shouldRunOnCurrentPlatform(cmd.Platforms) {
@@ -506,8 +506,6 @@ func (e *Executor) runCommand(ctx context.Context, t *ast.Task, call *Call, i in
 			if closeErr := closer(err); closeErr != nil {
 				e.Logger.Errf(logger.Red, "task: unable to close writer: %v\n", closeErr)
 			}
-		} else if err != nil {
-			taskOut.failed = true
 		}
 		if err != nil && timedOut(ctx, timeout) {
 			err = timeout
@@ -516,6 +514,9 @@ func (e *Executor) runCommand(ctx context.Context, t *ast.Task, call *Call, i in
 			e.Logger.VerboseErrf(logger.Yellow, "task: [%s] command error ignored: %v\n", t.Name(), err)
 			return nil
 		}
+		if taskOut != nil && err != nil {
+			taskOut.failed = true
+		}
 		return err
 	default:
 		return nil

task_test.go

@@ -2718,6 +2718,14 @@ func TestOutputGroupByTaskErrorOnly(t *testing.T) {
 	buff.Reset()
 	require.Error(t, e.Run(t.Context(), &task.Call{Task: "failing"}))
 	assert.Equal(t, "failing-first\nfailing-second\n", buff.String())
+
+	buff.Reset()
+	require.NoError(t, e.Run(t.Context(), &task.Call{Task: "ignored-command"}))
+	assert.Empty(t, buff.String())
+
+	buff.Reset()
+	require.NoError(t, e.Run(t.Context(), &task.Call{Task: "ignored-task"}))
+	assert.Equal(t, "child-failing-first\nchild-failing-second\n", buff.String())
 }
 
 func TestOutputGroupErrorOnlySwallowsOutputOnSuccess(t *testing.T) {

testdata/output_group_by_task_error_only/Taskfile.yml

@@ -17,3 +17,21 @@ tasks:
     cmds:
       - echo 'failing-first'
       - echo 'failing-second' && exit 1
+
+  ignored-command:
+    cmds:
+      - echo 'ignored-command-first'
+      - cmd: echo 'ignored-command-failure' && exit 1
+        ignore_error: true
+      - echo 'ignored-command-last'
+
+  child-failing:
+    cmds:
+      - echo 'child-failing-first'
+      - echo 'child-failing-second' && exit 1
+
+  ignored-task:
+    cmds:
+      - task: child-failing
+        ignore_error: true
+      - echo 'ignored-task-parent'