Fix browser script load error rejection - #6333
Open
rileyjshaw wants to merge 1 commit into
Open
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
rileyjshaw
marked this pull request as ready for review
August 11, 2026 14:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Errorinstead of the raw DOMEvent.error.cause.Why
When a MediaPipe WASM loader script fails to load, the browser dispatches a plain
Event. The current error listener passes that event directly to the Promise rejection. Callers therefore receive a non-Errorvalue with no useful message or stack, which obscures both the failed asset and where the load originated.The original callback also named the Promise rejection function
revoke, making the intended behavior less clear.Impact
This changes only the browser
<script>loading failure path. Successful loads and workerimportScripts()behavior are unchanged. Existing catch blocks continue to receive a rejection, now with a conventionalErrorvalue and richer diagnostic context.The project targets the ES2021 type library, which predates
ErrorOptions. The implementation therefore defines the standardcauseproperty explicitly instead of using the newer two-argumentErrorconstructor.Checks
mediapipe/web/graph_runner/BUILD: passedgit diff --check: passedbazelisk test //mediapipe/web/graph_runner:run_script_helper_test: blocked during target analysis by the current upstreamrules_javamodule resolving@rules_java~//tools/jdkwithout a BUILD file; no changed source was compiled before this failure