Add MPMask.getAsImageBitmap() for Web segmentation - #6343
Open
a2105z wants to merge 1 commit into
Open
Conversation
Insertable Streams / BreakoutBox need a GPU mask as ImageBitmap for VideoFrame without a Float32Array readback. Mirror MPImage: draw the RED channel as grayscale RGBA on an OffscreenCanvas and transferToImageBitmap(). Fixes google-ai-edge#4798
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MPImagealready hasgetAsImageBitmap().MPMask(confidence / category masks from ImageSegmenter, Interactive Segmenter, PoseLandmarker) did not. Segmentation effects on Insertable Streams / BreakoutBox / Web Workers want:Workarounds today are either
getAsFloat32Array()(GPU→CPUreadPixels) or pokingmask.canvas['GLctxObject']. Schmidt noted this was already on the internal list in 2023.Fixes #4798
API
vec4(m, m, m, m)to the OffscreenCanvas,transferToImageBitmap()— same sync GPU path asMPImage, no float readback.OffscreenCanvas(same limitation / error asMPImage.getAsImageBitmap()).MPMask;close()frees an owned bitmap.Test plan
mask.test.ts:hasImageBitmap()after conversion; grayscale pixels fromUint8ArrayandWebGLTexture; cache identity; clone owns a distinct bitmap; throws without a canvasbazel test //mediapipe/tasks/web/vision/core:mask_test(browser; skipped in Node like the existing mask tests)@schmidt-sebastian @kuaashish @HarishPermal @tyrmullen @kalyan2789g @akashvverma1995 @ayushgdev @lu-wang-g