Skip to content

Commit 381d374

Browse files
committed
test: point apigee-llm-proxy-url at the renamed test method
The apigee-llm-proxy-url surefire execution in core/pom.xml is meant to run one ApigeeLlmTest method with APIGEE_PROXY_URL set, so that ApigeeLlm's fallback to that environment variable is tested. It selects the method by name. df73784 replaced that method with three, including build_withoutProxyUrlAndEnvVarSet_readsFromEnvironment for this case, and did not update the execution, which still names build_withoutProxyUrl_readsFromEnvironment. Since then it runs no tests: [INFO] --- surefire:3.5.2:test (apigee-llm-proxy-url) @ google-adk --- [INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0 The new method skips itself unless APIGEE_PROXY_URL is set, and this is the only execution that sets it, so the build has skipped the method since the change. The build still passes because surefire's failIfNoSpecifiedTests check only looks for a matching test class, and ApigeeLlmTest still matches. Point the execution at the new method name.
1 parent 4092a1f commit 381d374

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

‎core/pom.xml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -305,7 +305,7 @@
305305
<goal>test</goal>
306306
</goals>
307307
<configuration>
308-
<test>ApigeeLlmTest#build_withoutProxyUrl_readsFromEnvironment</test>
308+
<test>ApigeeLlmTest#build_withoutProxyUrlAndEnvVarSet_readsFromEnvironment</test>
309309
<environmentVariables>
310310
<GOOGLE_API_KEY>api-key</GOOGLE_API_KEY>
311311
<!-- runs a second variant of the test method -->

0 commit comments

Comments
 (0)