Skip to content

docs: update firestore session service dependency versions and artifact identifiers - #1096

Merged
copybara-service[bot] merged 1 commit into
google:mainfrom
mohan-ganesh:firestore-session-updatereadme
Oct 22, 2026
Merged

copybara-service[bot] merged 1 commit into
google:mainfrom
mohan-ganesh:firestore-session-updatereadme

Conversation

@mohan-ganesh

Copy link
Copy Markdown
Contributor

Please ensure you have read the contribution guide before creating a pull request.

Link to Issue or Description of Change

1. Link to an existing issue (if applicable):
Not an issue

2. describe the change:
Updates the README.md to reflect the latest 1.0.1-rc.1-SNAPSHOT version and aligns the artifactId/groupId with the module's pom.xml configuration.

Problem:
Outdated version

Solution:
_Updates the README.md to reflect the latest 1.0.1-rc.1-SNAPSHOT version and aligns the artifactId/groupId with the module's pom.xml configuration.

Testing Plan

No functional changes made

Unit Tests:

  • [*] I have added or updated unit tests for my change.
  • [*] All unit tests pass locally.

Please include a summary of passed java test results.

Manual End-to-End (E2E) Tests:

Run the Sample Example depicted in README.md

Checklist

  • [*] I have read the CONTRIBUTING.md document.
  • [*] My pull request contains a single commit.
  • [*] I have performed a self-review of my own code.
  • [*] I have commented my code, particularly in hard-to-understand areas.
  • [*] I have added tests that prove my fix is effective or that my feature works.
  • [*] New and existing unit tests pass locally with my changes.
  • [*] I have manually tested my changes end-to-end.
  • [*] Any dependent changes have been merged and published in downstream modules.

Additional context

none

@glaforge
glaforge force-pushed the firestore-session-updatereadme branch from c296e71 to e99ff92 Compare April 7, 2026 08:47
@mohan-ganesh
mohan-ganesh force-pushed the firestore-session-updatereadme branch from 51d7007 to 0f38e3e Compare April 9, 2026 23:31
@mohan-ganesh
mohan-ganesh force-pushed the firestore-session-updatereadme branch from 0f38e3e to 80d719c Compare May 16, 2026 15:13
@mohan-ganesh

Copy link
Copy Markdown
Contributor Author

@glaforge I have successfully updated the branch via rebase. However, the GitHub Actions workflows are now awaiting maintainer approval to run. Could you please review and approve the workflows, and if they pass, with that it should be ready for merge.

@glaforge
glaforge force-pushed the firestore-session-updatereadme branch from 80d719c to c41072e Compare May 19, 2026 11:49
@hemasekhar-p hemasekhar-p self-assigned this Jul 17, 2026
@hemasekhar-p

Copy link
Copy Markdown
Contributor

Hi @mohan-ganesh, thank you for your contribution! We appreciate you taking the time to submit this pull request. As per PR contribution policy, please ensure your PR consists of a single commit. Could you please squash your commits accordingly?

@hemasekhar-p hemasekhar-p added the waiting on reporter Waiting for reaction by reporter. Failing that, maintainers will eventually closed it as stale. label Jul 17, 2026
@mohan-ganesh
mohan-ganesh force-pushed the firestore-session-updatereadme branch from fc4a953 to 109ca49 Compare July 18, 2026 14:37
@mohan-ganesh

Copy link
Copy Markdown
Contributor Author

@hemasekhar-p I have squashed the branch into a single commit as requested. Let me know if there's anything else needed!

@mohan-ganesh
mohan-ganesh force-pushed the firestore-session-updatereadme branch from 109ca49 to 90baf70 Compare July 18, 2026 14:45
@hemasekhar-p

Copy link
Copy Markdown
Contributor

@mohan-ganesh, thank you for squashing your changes into a single commit as requested. Currently this PR is under review by our team, we will keep you posted if any additional information is required. thank you.

@hemasekhar-p hemasekhar-p added needs review and removed waiting on reporter Waiting for reaction by reporter. Failing that, maintainers will eventually closed it as stale. labels Jul 23, 2026
Comment on lines +17 to +23
<version>1.0.0</version>
</dependency>
<!-- Firestore Session Service -->
<dependency>
<groupId>com.google.adk.contrib</groupId>
<artifactId>firestore-session-service</artifactId>
<version>0.4.0-SNAPSHOT</version>
<groupId>com.google.adk</groupId>
<artifactId>google-adk-firestore-session-service</artifactId>
<version>1.0.0</version>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the coordinates. 1.0.0 is already several releases behind (the latest is 1.12.0), so could you let release-please keep the version up to date instead of hardcoding it?

  1. Set the versions in both the Maven and Gradle snippets to 1.12.0, and wrap both snippets in release-please markers outside the code fences, like in the root README (

    adk-java/README.md

    Lines 47 to 63 in bad4f4c

    <!-- x-release-please-released-start-version -->
    ```xml
    <dependency>
    <groupId>com.google.adk</groupId>
    <artifactId>google-adk</artifactId>
    <version>1.12.0</version>
    </dependency>
    <!-- Dev UI -->
    <dependency>
    <groupId>com.google.adk</groupId>
    <artifactId>google-adk-dev</artifactId>
    <version>1.12.0</version>
    </dependency>
    ```
    <!-- x-release-please-released-end -->
    ):

    <!-- x-release-please-released-start-version -->
    ...Maven and Gradle snippets...
    <!-- x-release-please-released-end -->
    
  2. Add contrib/firestore-session-service/README.md to extra-files in release-please-config.json (

    "extra-files": [
    "core/src/main/java/com/google/adk/Version.java",
    "README.md"
    ]
    ). release-please only updates files listed there, so the markers alone won't do anything.

That way each release PR will bump these versions automatically, just like it does for the root README.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @damianmomotgoogle

Thanks for the great feedback and suggestion! Hooking this up to release-please is definitely a much better approach—it will go a long way in ensuring the dependency snippets stay automatically up to date with each new release rather than going stale.

I have addressed all the feedback and updated the PR:
Updated the dependency version in both the Maven and Gradle snippets to 1.12.0.

Wrapped both snippets in the and markers outside the code blocks.

Added contrib/firestore-session-service/README.md to extra-files in release-please-config.json so the automated bumps take effect.

Rebased and squashed everything into a single commit to keep history clean and satisfy the commit check.

Could you please take another look when you have a moment? Thanks!

@damianmomotgoogle damianmomotgoogle added waiting on reporter Waiting for reaction by reporter. Failing that, maintainers will eventually closed it as stale. and removed needs review labels Oct 15, 2026
@mohan-ganesh
mohan-ganesh force-pushed the firestore-session-updatereadme branch from a128303 to 5af3854 Compare October 18, 2026 15:54
@hemasekhar-p hemasekhar-p added needs review and removed waiting on reporter Waiting for reaction by reporter. Failing that, maintainers will eventually closed it as stale. labels Oct 19, 2026
@copybara-service
copybara-service Bot merged commit 29616c7 into google:main Oct 22, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants