Repository navigation
docs: update firestore session service dependency versions and artifact identifiers - #1096
Conversation
c296e71 to
e99ff92
Compare
51d7007 to
0f38e3e
Compare
0f38e3e to
80d719c
Compare
|
@glaforge I have successfully updated the branch via rebase. However, the GitHub Actions workflows are now awaiting maintainer approval to run. Could you please review and approve the workflows, and if they pass, with that it should be ready for merge. |
80d719c to
c41072e
Compare
|
Hi @mohan-ganesh, thank you for your contribution! We appreciate you taking the time to submit this pull request. As per PR contribution policy, please ensure your PR consists of a single commit. Could you please squash your commits accordingly? |
fc4a953 to
109ca49
Compare
|
@hemasekhar-p I have squashed the branch into a single commit as requested. Let me know if there's anything else needed! |
109ca49 to
90baf70
Compare
|
@mohan-ganesh, thank you for squashing your changes into a single commit as requested. Currently this PR is under review by our team, we will keep you posted if any additional information is required. thank you. |
| <version>1.0.0</version> | ||
| </dependency> | ||
| <!-- Firestore Session Service --> | ||
| <dependency> | ||
| <groupId>com.google.adk.contrib</groupId> | ||
| <artifactId>firestore-session-service</artifactId> | ||
| <version>0.4.0-SNAPSHOT</version> | ||
| <groupId>com.google.adk</groupId> | ||
| <artifactId>google-adk-firestore-session-service</artifactId> | ||
| <version>1.0.0</version> |
There was a problem hiding this comment.
Thanks for updating the coordinates. 1.0.0 is already several releases behind (the latest is 1.12.0), so could you let release-please keep the version up to date instead of hardcoding it?
-
Set the versions in both the Maven and Gradle snippets to
1.12.0, and wrap both snippets in release-please markers outside the code fences, like in the root README ():Lines 47 to 63 in bad4f4c
<!-- x-release-please-released-start-version --> ...Maven and Gradle snippets... <!-- x-release-please-released-end --> -
Add
contrib/firestore-session-service/README.mdtoextra-filesinrelease-please-config.json(). release-please only updates files listed there, so the markers alone won't do anything.adk-java/release-please-config.json
Lines 7 to 10 in bad4f4c
That way each release PR will bump these versions automatically, just like it does for the root README.
There was a problem hiding this comment.
Thanks for the great feedback and suggestion! Hooking this up to release-please is definitely a much better approach—it will go a long way in ensuring the dependency snippets stay automatically up to date with each new release rather than going stale.
I have addressed all the feedback and updated the PR:
Updated the dependency version in both the Maven and Gradle snippets to 1.12.0.
Wrapped both snippets in the and markers outside the code blocks.
Added contrib/firestore-session-service/README.md to extra-files in release-please-config.json so the automated bumps take effect.
Rebased and squashed everything into a single commit to keep history clean and satisfy the commit check.
Could you please take another look when you have a moment? Thanks!
…ct identifiers...
a128303 to
5af3854
Compare
Please ensure you have read the contribution guide before creating a pull request.
Link to Issue or Description of Change
1. Link to an existing issue (if applicable):
Not an issue
2. describe the change:
Updates the README.md to reflect the latest 1.0.1-rc.1-SNAPSHOT version and aligns the artifactId/groupId with the module's pom.xml configuration.
Problem:
Outdated version
Solution:
_Updates the README.md to reflect the latest 1.0.1-rc.1-SNAPSHOT version and aligns the artifactId/groupId with the module's pom.xml configuration.
Testing Plan
No functional changes made
Unit Tests:
Please include a summary of passed java test results.
Manual End-to-End (E2E) Tests:
Run the Sample Example depicted in README.md
Checklist
Additional context
none