Skip to content

Commit da46f8a

Browse files
GWealecopybara-github
authored andcommitted
chore(plugins): drop a stale note about uncached tool declarations
Co-authored-by: George Weale <gweale@google.com> PiperOrigin-RevId: 958554447
1 parent 07add3b commit da46f8a

1 file changed

Lines changed: 0 additions & 5 deletions

File tree

src/google/adk/plugins/bigquery_agent_analytics_plugin.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -374,11 +374,6 @@ def _extract_tool_declarations(
374374
# The parameter schema lives on the tool's FunctionDeclaration, which some
375375
# tools (e.g. built-in tools) do not provide. Resolve defensively so a
376376
# single failing tool does not discard the whole tools list.
377-
#
378-
# Note: FunctionTool._get_declaration() rebuilds the declaration from the
379-
# function signature on each call (no caching), so this repeats work the
380-
# framework already did when assembling the request. Acceptable for typical
381-
# toolsets; revisit with a cache if it shows up on the hot path.
382377
declaration = None
383378
try:
384379
get_declaration = getattr(tool, "_get_declaration", None)

0 commit comments

Comments
 (0)