Add Kotoba v1 Draco magic/header binding - #1220
Open
com-junkawasaki wants to merge 3 commits into
Open
Conversation
Parse DRACO magic plus DracoHeader version and encoded type from an 11-byte vendored mesh fixture. Kotoba 0.7.2 wasm32 i64-v1 only; no mesh decode, encode, FFI, or robotics claim. Fork CI runs checks.sh. Co-authored-by: Jun Kawasaki <04.feasts_minded@icloud.com>
Path-ignore on that workflow was skipped because this PR also edited ci.yml. Leave the upstream matrix alone; kotoba.yml is the fork check. Co-authored-by: Jun Kawasaki <04.feasts_minded@icloud.com>
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
draco-ci must skip kotoba/** and .github/workflows/kotoba.yml so a header-only binding does not enqueue the C++/JS matrix. Co-authored-by: Jun Kawasaki <04.feasts_minded@icloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a first-class
kotoba/sibling next tosrc/(C++) andjavascript/.What this is
v1 parse of the Draco bitstream magic
DRACOplusDracoHeaderfields (bitstream version, encoded type) from an 11-byte vendored header prefix. Compiles to host-independent wasm32 with kotoba CLI v0.7.2 (no FFI, no IEEE floats).What this is not
Layout matches
src/draco/compression/config/compression_shared.h(DracoHeader).Checks
kotoba/checks.shcompiles the module and compares the packed result to the fixture bytes. Fork workflow is on kotoba-lang#1. This PR does not claim that workflow has already gone green.Google CLA may apply for this contribution.
Fork PR: kotoba-lang#1