filamentapp: support screenshot for all sample apps - #10375
Open
poweifeng wants to merge 1 commit into
Open
Conversation
This can be useful for adding to the renderdiff CI test framework. For output, we add another abstraction AssetWriter. This is to anticipate for cases where we cannot write to disk for certain platforms. Also, fix startTime init in procedural_effect to ensure elapsed time is not off by one frame. (Note that originally 'startTime' will be set to 'now' for two frames).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This can be useful for adding to the renderdiff CI test framework.
For output, we add another abstraction AssetWriter. This is to anticipate for cases where we cannot write to disk for certain platforms.
Also, fix startTime init in procedural_effect to ensure elapsed time is not off by one frame. (Note that originally 'startTime' will be set to 'now' for two frames).