Skip to content

Commit 4c694cc

Browse files
authored
test: include acceptance tests in update-snapshots target (#2921)
## Overview Updates the `make update-snapshots` command target in the Makefile to run both unit tests and acceptance tests, matching the behavior of `make test SNAPS=true ACC=true SHORT=false`. ## Details - Modified `update-snapshots` Makefile target to run `$(MAKE) test SNAPS=true ACC=true SHORT=false`. - Updated `CONTRIBUTING.md` description for `make update-snapshots`. - Regenerated all snapshot and cassette files. ## Testing - Ran `./scripts/run_lints.sh` and verified 0 lint issues. - Ran `make update-snapshots` to verify all unit and acceptance tests successfully pass. ## Checklist - [x] I have signed the Contributor License Agreement. - [x] I have run the linter using `./scripts/run_lints.sh`. - [x] I have run the unit tests using `./scripts/run_tests.sh`. - [x] I have made my commits and PR title follow the Conventional Commits specification. agy
1 parent 3e4dfbe commit 4c694cc

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ Note that some long-running tests may be skipped and their snapshots will not be
126126

127127
```shell
128128
make update-snapshots
129-
# Equivalent to: make test SNAPS=true SHORT=false
129+
# Equivalent to: make test SNAPS=true ACC=true SHORT=false
130130
```
131131

132132
To update all snapshots for all tests, matching the CI test environment, use:

Makefile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,8 +57,8 @@ test: ## Run tests
5757
if [ "$(SHORT)" = "true" ]; then ARGS="$$ARGS -short"; fi; \
5858
scripts/run_tests.sh $$ARGS
5959

60-
update-snapshots: ## Update all snapshots (Equivalent to make test SNAPS=true SHORT=false)
61-
$(MAKE) test SNAPS=true SHORT=false
60+
update-snapshots: ## Update all snapshots (Equivalent to make test SNAPS=true ACC=true SHORT=false)
61+
$(MAKE) test SNAPS=true ACC=true SHORT=false
6262

6363
refresh-all: ## Refresh all snaps, matching CI test (Usage: make refresh-all REBUILD_IMAGES=true)
6464
@if [ "$(REBUILD_IMAGES)" = "true" ]; then $(MAKE) clean; fi

0 commit comments

Comments
 (0)