Repository navigation
Conversation
andreanadr
approved these changes
Feb 8, 2024
NinoDLC
reviewed
May 14, 2024
| } | ||
|
|
||
| buildFeatures { | ||
| buildConfig(true) // make sure this is set |
There was a problem hiding this comment.
Suggested change
| buildConfig(true) // make sure this is set | |
| buildConfig = true // make sure this is set |
This is more idiomatic to Kotlin
Contributor
dkhawk
added a commit
that referenced
this pull request
Oct 23, 2026
- Use pluginManager.withPlugin across com.android.application, com.android.library, com.android.test, and com.android.dynamic-feature (#62, #91) - Support unitTest and androidTest manifest placeholder injection across AGP 8.0-8.2 (HasUnitTest/HasAndroidTest) and AGP 8.3+/9.x (nestedComponents) (#41, #89, #96, #104) - Guard variant.buildConfigFields behind isBuildConfigEnabled so projects with buildFeatures.buildConfig=false emit zero warnings (#87) - Fix empty string ("") and backslash escaping in addParenthesisIfNeeded (#72, #81, #99) - Add 5-level property precedence with combined <variantName>.properties and module-local file fallback (#59) - Use Gradle Provider API (providers.fileContents) for Configuration Cache and Isolated Projects compatibility - Set kotlin.stdlib.default.dependency=false and compileOnly(libs.kotlin.stdlib) for zero runtime dependency leakage - Configure MavenPublication POM metadata (#28) - Add 3-tier automated test suite: 12 unit tests (SecretsPluginTest), 6 real-AGP Gradle TestKit functional tests (SecretsPluginFunctionalTest), and sample-app integration test (SecretsInjectionTest)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.