Skip to content

Include build plugin project and show keys in MainActivity - #95

Merged
dkhawk merged 5 commits into
google:mainfrom
Goooler:include-build-plugin
Oct 23, 2026
Merged

dkhawk merged 5 commits into
google:mainfrom
Goooler:include-build-plugin

Conversation

@Goooler

@Goooler Goooler commented Sep 5, 2024

Copy link
Copy Markdown
Contributor

It would be easier to test the plugin logic in the sample App, we don't have to rely on the published version.

It would be easier to test the plugin logic in the sample App, we don't have to rely on the published version.
@Goooler

This comment was marked as outdated.

@Goooler
Goooler force-pushed the include-build-plugin branch from 26df786 to c383224 Compare September 5, 2024 11:38
@Goooler Goooler changed the title Include build plugin project and show gmpApiKey in MainActivity Include build plugin project and show keys in MainActivity Sep 5, 2024

@dkhawk dkhawk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Goooler! Switching the root project to includeBuild("secrets-gradle-plugin") and displaying both the BuildConfig and AndroidManifest keys in MainActivity makes testing the local plugin in :sample-app much cleaner.

@Goooler

Goooler commented Oct 23, 2026

Copy link
Copy Markdown
Contributor Author
CRITICAL: The following mandatory checks failed:
- zizmor/unpinned-uses at line 32 of .github/workflows/test.yml: unpinned action reference: action is not pinned to a hash (required by blanket policy)
- zizmor/unpinned-uses at line 35 of .github/workflows/test.yml: unpinned action reference: action is not pinned to a hash (required by blanket policy)

Unrelated failure, needs to fix them separately.

@dkhawk
dkhawk merged commit 0235f4f into google:main Oct 23, 2026
5 of 6 checks passed
@Goooler
Goooler deleted the include-build-plugin branch October 24, 2026 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants