chore(ci): build release assets from trigger tag - #1528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that we have a
v2branch that we want to make a release candidate from, we need to ensure that if we tag a release from that branch, we build release assets from that tag specifically - not frommain. This changes thecheckoutaction to specifically checkout the release tag prior to building anything.This is also a general improvement for the
mainbranch as it ensures the assets we build/upload are from the exact same tag rather than whatever is inmainwhen the release was created (which may be after the tag was created in non-Release-Please cases, which would be exceptional).