Skip to content

Commit 0f05a1a

Browse files
committed
fix(migration): resolve GHA build blocks and native-image issues
- Declared missing direct dependencies (maven-resolver-api, guava) in validate-bom tests. - Stripped carriage returns (\r) from pre-install script outputs for Windows GHA runner compatibility. - Deleted test native-image.properties in java-spanner-jdbc to prevent build-time initialization failures. - Resolved merge conflicts in versions.txt.
1 parent c840eeb commit 0f05a1a

4 files changed

Lines changed: 6 additions & 13 deletions

File tree

‎java-cloud-bom/tests/pre-install.sh‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ set -eo pipefail
2727
for f in $(find . -maxdepth 1 -name "java-*" | grep -v "java-cloud-bom" | grep -v "java-shared-config" | grep -v "java-showcase" | grep -v "java-samples"); do
2828
echo "$f" | sed 's|^\./||'
2929
done
30-
) | tr '\n' ',' | sed 's/,$//' > bom_projects.txt
30+
) | tr -d '\r' | tr '\n' ',' | sed 's/,$//' > bom_projects.txt
3131

3232
mvn install -pl $(cat bom_projects.txt) -am -amd -DskipTests=true -Dmaven.javadoc.skip=true -Dcheckstyle.skip=true -Denforcer.skip=true -Danimal.sniffer.skip=true -Dclirr.skip=true -Dgcloud.download.skip=true -B -V -T 1C -l java-cloud-bom/tests/mvn-install.log
3333
rm bom_projects.txt

‎java-cloud-bom/tests/validate-bom/pom.xml‎

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -61,16 +61,13 @@
6161
<version>1.5.15</version>
6262
</dependency>
6363
<dependency>
64-
<groupId>junit</groupId>
65-
<artifactId>junit</artifactId>
66-
<version>4.13.1</version>
67-
<scope>test</scope>
64+
<groupId>org.apache.maven.resolver</groupId>
65+
<artifactId>maven-resolver-api</artifactId>
6866
</dependency>
6967
<dependency>
70-
<groupId>com.google.truth</groupId>
71-
<artifactId>truth</artifactId>
72-
<version>1.4.5</version>
73-
<scope>test</scope>
68+
<groupId>com.google.guava</groupId>
69+
<artifactId>guava</artifactId>
70+
<version>30.1.1-jre</version>
7471
</dependency>
7572
</dependencies>
7673

‎java-spanner-jdbc/src/test/resources/META-INF/native-image/com.google.cloud/google-cloud-spanner-jdbc/native-image.properties‎

Lines changed: 0 additions & 1 deletion
This file was deleted.

‎versions.txt‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1059,14 +1059,11 @@ google-cloud-developer-knowledge:0.1.0:0.2.0-SNAPSHOT
10591059
proto-google-cloud-developer-knowledge-v1:0.1.0:0.2.0-SNAPSHOT
10601060
grpc-google-cloud-developer-knowledge-v1:0.1.0:0.2.0-SNAPSHOT
10611061
google-cloud-backstory:0.1.0:0.2.0-SNAPSHOT
1062-
<<<<<<< migrate-java-cloud-bom
10631062
google-cloud-bom:0.265.0:0.266.0-SNAPSHOT
10641063
libraries-bom:26.84.0:26.85.0-SNAPSHOT
10651064
java-cloud-bom-tests:0.80.0:0.81.0-SNAPSHOT
10661065
full-convergence-check:0.83.0:0.84.0-SNAPSHOT
1067-
=======
10681066
google-cloud-shared-config:1.17.0:1.17.1-SNAPSHOT
1069-
>>>>>>> main
10701067
proto-google-cloud-agentregistry-v1:0.0.0:0.1.0-SNAPSHOT
10711068
grpc-google-cloud-agentregistry-v1:0.0.0:0.1.0-SNAPSHOT
10721069
google-cloud-agentregistry:0.0.0:0.1.0-SNAPSHOT

0 commit comments

Comments
 (0)