Repository navigation
Commit 32cfd9a
Dhriti Chopra
feat(storage): reject fast open configs that are not a single read
Third step of fast open BiDi reads (go/fast-open-bidi-read, b/552263062).
A fast open read is sent as one range in the open request, so only configs
that make a single read on the stream (asFutureBytes, asFutureByteString,
asChannel) can be one. asSeekableChannel issues reads as the caller seeks, so
it cannot. readSession now rejects it with an IllegalArgumentException before
anything is sent, instead of failing with an UnsupportedOperationException
while creating the read.1 parent e9de87e commit 32cfd9a
2 files changed
Lines changed: 22 additions & 0 deletions
File tree
- java-storage/google-cloud-storage/src
- main/java/com/google/cloud/storage
- test/java/com/google/cloud/storage
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
84 | 84 | | |
85 | 85 | | |
86 | 86 | | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
87 | 91 | | |
88 | 92 | | |
89 | 93 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
268 | 268 | | |
269 | 269 | | |
270 | 270 | | |
| 271 | + | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
| 275 | + | |
| 276 | + | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
| 286 | + | |
| 287 | + | |
| 288 | + | |
271 | 289 | | |
272 | 290 | | |
273 | 291 | | |
| |||
0 commit comments