Repository navigation
chore: expose the user set executor on TransportProvider #13557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
aa92a9c
chore: expose user set executor on TransportProvider
igorbernstein2 bcb99a6
Merge branch 'main' into tp-executor
igorbernstein2 a9055c2
return null
igorbernstein2 f087d01
remove unnecessary impl
igorbernstein2 d0c3d6c
stray import
igorbernstein2 233c35a
doc
igorbernstein2 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -36,6 +36,7 @@ | |
| import java.util.Map; | ||
| import java.util.concurrent.Executor; | ||
| import java.util.concurrent.ScheduledExecutorService; | ||
| import javax.annotation.Nullable; | ||
|
|
||
| /** | ||
| * Provides an interface to either build a TransportChannel or provide a fixed TransportChannel that | ||
|
|
@@ -70,6 +71,16 @@ public interface TransportChannelProvider { | |
| @Deprecated | ||
| boolean needsExecutor(); | ||
|
|
||
| /** | ||
| * @return the user provided executor. This can be null if the user didn't override the executor | ||
| * and the TransportProvider is using its internal executor. | ||
| * @throws UnsupportedOperationException if the TransportProvider doesn't support this method. | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I might missed this earlier, Java doc needs to be updated as well. |
||
| */ | ||
| @Nullable | ||
| default Executor getExecutor() { | ||
| return null; | ||
| } | ||
|
|
||
| /** Sets the executor to use when constructing a new {@link TransportChannel}. */ | ||
| TransportChannelProvider withExecutor(Executor executor); | ||
|
|
||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.