Skip to content

Commit 25710ee

Browse files
committed
fix(gax): remove gcp.client.language log attribute
1 parent 952d3f1 commit 25710ee

2 files changed

Lines changed: 0 additions & 6 deletions

File tree

‎core/packages/gax/src/observability/LoggerHelper.ts‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,6 @@ export interface LogPayload {
5252
'gcp.client.repo'?: string;
5353
'gcp.client.artifact'?: string;
5454
'gcp.client.version'?: string;
55-
'gcp.client.language'?: 'node';
5655
'gcp.client.service'?: string;
5756
'url.domain'?: string;
5857
'server.address'?: string;
@@ -254,7 +253,6 @@ export function buildLogAttributes(
254253
(attributes as Record<string, unknown>)[key] = value;
255254
}
256255
}
257-
attributes['gcp.client.language'] = 'node';
258256
if (rawAddress !== undefined && !isPreConnectionFailure(err)) {
259257
attributes['server.address'] = rawAddress;
260258
}

‎core/packages/gax/test/unit/loggerHelper.ts‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -223,7 +223,6 @@ describe('LoggerHelper', () => {
223223
'gcp.client.version': '1.2.3',
224224
'gcp.client.repo': DEFAULT_GCP_REPO,
225225
'gcp.client.artifact': '@google-cloud/storage',
226-
'gcp.client.language': 'node',
227226
'rpc.system.name': 'grpc',
228227
'rpc.method': 'google.storage.v2.Storage/GetObject',
229228
'url.domain': 'storage.googleapis.com',
@@ -255,7 +254,6 @@ describe('LoggerHelper', () => {
255254
);
256255

257256
assert.deepStrictEqual(attributes, {
258-
'gcp.client.language': 'node',
259257
'rpc.system.name': 'http',
260258
'rpc.response.status_code': 'NOT_FOUND',
261259
'http.response.status_code': 404,
@@ -524,7 +522,6 @@ describe('LoggerHelper', () => {
524522
'gcp.client.version': '1.2.3',
525523
'gcp.client.repo': DEFAULT_GCP_REPO,
526524
'gcp.client.artifact': '@google-cloud/storage',
527-
'gcp.client.language': 'node',
528525
'rpc.system.name': 'grpc',
529526
'rpc.method': 'google.storage.v2.Storage/GetObject',
530527
'url.domain': 'storage.googleapis.com',
@@ -940,7 +937,6 @@ describe('LoggerHelper', () => {
940937
'gcp.client.version': '1.2.3',
941938
'gcp.client.repo': DEFAULT_GCP_REPO,
942939
'gcp.client.artifact': '@google-cloud/storage',
943-
'gcp.client.language': 'node',
944940
'rpc.system.name': 'grpc',
945941
'rpc.method': 'google.storage.v2.Storage/GetObject',
946942
'url.domain': 'storage.googleapis.com',

0 commit comments

Comments
 (0)