[Address CI errors] test: support function stubs and guard read-only properties in proxyquire helper

Author: danieljbruce

handwritten/bigtable/test/proxyquire.ts

@@ -24,8 +24,9 @@ const mod = Module as unknown as {
   _resolveFilename: (request: string, parent: NodeModule) => string;
 };
 const {hasOwnProperty} = Object.prototype;
-const hasOwn = (o: unknown, k: string) =>
-  Boolean(o && typeof o === 'object' && hasOwnProperty.call(o, k));
+const isObj = (o: unknown) =>
+  Boolean(o && (typeof o === 'object' || typeof o === 'function'));
+const hasOwn = (o: unknown, k: string) => isObj(o) && hasOwnProperty.call(o, k);
 const isGlobal = (s: unknown) =>
   hasOwn(s, '@global') || hasOwn(s, '@runtimeGlobal');
 const resolveFrom = (base: string, req: string) => {
@@ -76,7 +77,13 @@ function proxyquire<T = any>(request: string, stubs: Stubs = {}): T {
               const real = prev.call(this, id);
               if (real && ['object', 'function'].includes(typeof real)) {
                 for (const k of Object.keys(real)) {
-                  if (!(k in stub)) stub[k] = real[k];
+                  if (!(k in stub)) {
+                    try {
+                      stub[k] = real[k];
+                    } catch {
+                      // ignore
+                    }
+                  }
                 }
               }
             } catch {

handwritten/spanner/test/proxyquire.ts

@@ -24,8 +24,9 @@ const mod = Module as unknown as {
   _resolveFilename: (request: string, parent: NodeModule) => string;
 };
 const {hasOwnProperty} = Object.prototype;
-const hasOwn = (o: unknown, k: string) =>
-  Boolean(o && typeof o === 'object' && hasOwnProperty.call(o, k));
+const isObj = (o: unknown) =>
+  Boolean(o && (typeof o === 'object' || typeof o === 'function'));
+const hasOwn = (o: unknown, k: string) => isObj(o) && hasOwnProperty.call(o, k);
 const isGlobal = (s: unknown) =>
   hasOwn(s, '@global') || hasOwn(s, '@runtimeGlobal');
 const resolveFrom = (base: string, req: string) => {
@@ -76,7 +77,13 @@ function proxyquire<T = any>(request: string, stubs: Stubs = {}): T {
               const real = prev.call(this, id);
               if (real && ['object', 'function'].includes(typeof real)) {
                 for (const k of Object.keys(real)) {
-                  if (!(k in stub)) stub[k] = real[k];
+                  if (!(k in stub)) {
+                    try {
+                      stub[k] = real[k];
+                    } catch {
+                      // ignore
+                    }
+                  }
                 }
               }
             } catch {

handwritten/storage/test/proxyquire.ts

@@ -24,8 +24,9 @@ const mod = Module as unknown as {
   _resolveFilename: (request: string, parent: NodeModule) => string;
 };
 const {hasOwnProperty} = Object.prototype;
-const hasOwn = (o: unknown, k: string) =>
-  Boolean(o && typeof o === 'object' && hasOwnProperty.call(o, k));
+const isObj = (o: unknown) =>
+  Boolean(o && (typeof o === 'object' || typeof o === 'function'));
+const hasOwn = (o: unknown, k: string) => isObj(o) && hasOwnProperty.call(o, k);
 const isGlobal = (s: unknown) =>
   hasOwn(s, '@global') || hasOwn(s, '@runtimeGlobal');
 const resolveFrom = (base: string, req: string) => {
@@ -76,7 +77,13 @@ function proxyquire<T = any>(request: string, stubs: Stubs = {}): T {
               const real = prev.call(this, id);
               if (real && ['object', 'function'].includes(typeof real)) {
                 for (const k of Object.keys(real)) {
-                  if (!(k in stub)) stub[k] = real[k];
+                  if (!(k in stub)) {
+                    try {
+                      stub[k] = real[k];
+                    } catch {
+                      // ignore
+                    }
+                  }
                 }
               }
             } catch {