fix(gax): reuse buildLogAttributes exception attributes in logNetworkAttempt

Author: shivanee-p

core/packages/gax/src/observability/LoggerHelper.ts

@@ -319,7 +319,6 @@ export function logNetworkAttempt<T = GaxCallResult>(
     }
 
     // Emit structured DEBUG log for the failed attempt.
-    const message = resolveExceptionMessage(err, attemptDynamicArgs.rpcType);
     logger(
       {
         severity: resolveLogSeverity('DEBUG'),
@@ -328,7 +327,7 @@ export function logNetworkAttempt<T = GaxCallResult>(
         other: attributes,
       },
       'RPC attempt failed: %s',
-      message || err,
+      attributes['exception.message'] || err,
     );
   };
 

core/packages/gax/test/unit/loggerHelper.ts

@@ -748,14 +748,15 @@ describe('LoggerHelper', () => {
         'rpc.system.name': 'grpc',
         'rpc.method': 'google.storage.v2.Storage/GetObject',
         'url.domain': 'storage.googleapis.com',
+        'server.address': 'storage.googleapis.com',
         'rpc.response.status_code': 'UNAVAILABLE',
         'error.type': 'UNAVAILABLE',
+        'exception.type': 'GoogleError',
+        'exception.message': 'Unavailable',
+        'exception.stacktrace': errWithMeta.stack,
         'response.payload':
           '{"x-goog-request-id":"req-123","trace-bin":"YWJj"}',
       });
-      assert.strictEqual('exception.type' in other, false);
-      assert.strictEqual('exception.message' in other, false);
-      assert.strictEqual('exception.stacktrace' in other, false);
 
       sink.reset();
       const preConnectGrpcErr = Object.assign(
@@ -803,9 +804,13 @@ describe('LoggerHelper', () => {
       ]);
       const otherWithoutMeta = sink.logs[0].fields.other as LogPayload;
       assert.strictEqual('response.payload' in otherWithoutMeta, false);
-      assert.strictEqual('exception.type' in otherWithoutMeta, false);
-      assert.strictEqual('exception.message' in otherWithoutMeta, false);
-      assert.strictEqual('exception.stacktrace' in otherWithoutMeta, false);
+      assert.strictEqual('server.address' in otherWithoutMeta, false);
+      assert.strictEqual(otherWithoutMeta['exception.type'], 'TypeError');
+      assert.strictEqual(otherWithoutMeta['exception.message'], 'client error');
+      assert.strictEqual(
+        otherWithoutMeta['exception.stacktrace'],
+        errWithoutMeta.stack,
+      );
     });
 
     it('emits response.payload on HTTP REST error responses and omits it on empty or transport failures', async () => {